Skip to content

Conversation

@ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jan 8, 2026

This error message is hard to discern and is missing info.
I hope to solve this problem in this PR.

The error now prints as: (after I added a bug to the first expect [BlockTimestamp(1767898129)]

---- scraper_end_to_end stdout ----
Expected: [L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x0), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x1, 0x2]) }, tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x1), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x3, 0x4]) }, tx_hash: TransactionHash(0x15b9bd084a567d1a82bc8e5953b477611a867b9f18247487c4e65b8d7f509e1), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, TransactionCancellationStarted { tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), cancellation_request_timestamp: BlockTimestamp(1767898129) }]
Actual: [L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x0), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x1, 0x2]) }, tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x1), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x3, 0x4]) }, tx_hash: TransactionHash(0x15b9bd084a567d1a82bc8e5953b477611a867b9f18247487c4e65b8d7f509e1), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, TransactionCancellationStarted { tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), cancellation_request_timestamp: BlockTimestamp(1767898128) }]
Expected: []
Actual: [L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x0), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x1, 0x2]) }, tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x1), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x3, 0x4]) }, tx_hash: TransactionHash(0x15b9bd084a567d1a82bc8e5953b477611a867b9f18247487c4e65b8d7f509e1), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, TransactionCancellationStarted { tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), cancellation_request_timestamp: BlockTimestamp(1767898128) }]

thread 'scraper_end_to_end' (1630870) panicked at crates/apollo_l1_provider_types/src/lib.rs:108:44:
MockL1ProviderClient::add_events([L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x0), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x1, 0x2]) }, tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, L1HandlerTransaction { l1_handler_tx: L1HandlerTransaction { tx: L1HandlerTransaction { version: TransactionVersion(0x0), nonce: Nonce(0x1), contract_address: ContractAddress(PatriciaKey(0x12)), entry_point_selector: EntryPointSelector(0x34), calldata: Calldata([0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, 0x3, 0x4]) }, tx_hash: TransactionHash(0x15b9bd084a567d1a82bc8e5953b477611a867b9f18247487c4e65b8d7f509e1), paid_fee_on_l1: Fee(1) }, block_timestamp: BlockTimestamp(1767898128), scrape_timestamp: 1767898128 }, TransactionCancellationStarted { tx_hash: TransactionHash(0x729e0563244d7bbf5f7f387c8801698e602aba18a29a5c902eca3df0ab33164), cancellation_request_timestamp: BlockTimestamp(1767898128) }]): No matching expectation found
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware marked this pull request as ready for review January 8, 2026 18:58
Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware).


crates/apollo_integration_tests/tests/l1_events_scraper_end_to_end.rs line 143 at r1 (raw file):

    let expected_cancel_message = Event::TransactionCancellationStarted {
        tx_hash: tx_hash_first_tx,
        cancellation_request_timestamp: BlockTimestamp(cancel_timestamp.0 + 1),

Why add one?

@guy-starkware guy-starkware force-pushed the arni/integration_tests/scraper_end_to_end/check_events_eq_fn branch from 446afcd to 0010ae7 Compare January 11, 2026 11:32
@guy-starkware guy-starkware force-pushed the arni/integration_tests/scraper_end_to_end/check_events_eq_fn branch from 0010ae7 to aa77e4d Compare January 11, 2026 11:32
Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ArniStarkware).

Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware).

@guy-starkware guy-starkware added this pull request to the merge queue Jan 11, 2026
Merged via the queue into main-v0.14.1-committer with commit 37cad2f Jan 11, 2026
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants