blockifier: get proof_facts_length from tx#11998
Merged
avivg-starkware merged 1 commit intomain-v0.14.2from Jan 28, 2026
Merged
blockifier: get proof_facts_length from tx#11998avivg-starkware merged 1 commit intomain-v0.14.2from
avivg-starkware merged 1 commit intomain-v0.14.2from
Conversation
|
This change is |
This was referenced Jan 26, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
18019c2 to
fcaf8e0
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
ebbbd61 to
36df384
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
fcaf8e0 to
dbba779
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
2 times, most recently
from
0c7a7d5 to
f1ae88f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
dbba779 to
0a034a9
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
f1ae88f to
df6a7d6
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
0a034a9 to
a9a2230
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
df6a7d6 to
fffccef
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
a9a2230 to
7c7f37e
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
fffccef to
67805fa
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
2 times, most recently
from
2018def to
d4e9ba8
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
67805fa to
05d9bb4
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
05d9bb4 to
f55342b
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
2 times, most recently
from
456ccf5 to
ec8a534
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
f55342b to
e7947fd
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
ec8a534 to
f966a86
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
e7947fd to
58d50f5
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
f966a86 to
4311172
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
58d50f5 to
cf6e9d2
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
4311172 to
98ff288
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
2 times, most recently
from
b376ab4 to
5b13127
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
98ff288 to
daa5428
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
5b13127 to
f2a33b3
Compare
meship-starkware
requested changes
Jan 28, 2026
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware reviewed 3 files and made 1 comment.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1).
crates/blockifier/src/transaction/transactions_test.rs line 629 at r3 (raw file):
// Skip impossible combination: proof_facts only exist in V3 transactions, // and V3 uses AllResourceBounds (L1Gas is legacy-only). ValidResourceBounds::L1Gas(_) => return,
I think we should panic here; no test should cover this case.
Code quote:
// Skip impossible combination: proof_facts only exist in V3 transactions,
// and V3 uses AllResourceBounds (L1Gas is legacy-only).
ValidResourceBounds::L1Gas(_) => return,
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1).
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
f2a33b3 to
77d0fd0
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
daa5428 to
9de48e0
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
77d0fd0 to
92eef52
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_proof_facts_let_to_tx_params
branch
from
9de48e0 to
1303a29
Compare
avivg-starkware
commented
Jan 28, 2026
Contributor
Author
avivg-starkware
left a comment
avivg-starkware
left a comment
There was a problem hiding this comment.
@avivg-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1).
crates/blockifier/src/transaction/transactions_test.rs line 629 at r3 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
I think we should panic here; no test should cover this case.
I used return here so the parametrized test skips an invalid combination (proof_facts + L1Gas) that can’t occur in production. If we panic!/unreachable!, this specific generated case will fail the suite even though it’s not a meaningful scenario to test.
avivg-starkware
changed the base branch from
avivg/blockifier/add_proof_facts_let_to_tx_params
to
graphite-base/11998
avivg-starkware
force-pushed
the
graphite-base/11998
branch
from
1303a29 to
7c12ba9
Compare
avivg-starkware
force-pushed
the
avivg/blockifer/get_proof_facts_len_from_tx
branch
from
92eef52 to
3c253cb
Compare
avivg-starkware
changed the base branch from
graphite-base/11998
to
main-v0.14.2
meship-starkware
approved these changes
Jan 28, 2026
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.