Skip to content

Comments

apollo_propeller: add MessageProcessor scaffolding#12003

Merged
sirandreww-starkware merged 1 commit intomain-v0.14.2from
01-26-apollo_propeller_add_messageprocessor_scaffolding
Feb 22, 2026
Merged

apollo_propeller: add MessageProcessor scaffolding#12003
sirandreww-starkware merged 1 commit intomain-v0.14.2from
01-26-apollo_propeller_add_messageprocessor_scaffolding

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 26, 2026

Note

Low Risk
Mostly scaffolding and wiring for a new async component; behavior change is limited to emitting timeout/finalization events once the processor is instantiated and run.

Overview
Adds a new message_processor module exposing a MessageProcessor task skeleton for per-message processing, including an engine-facing EventStateManagerToEngine channel protocol.

The processor currently implements timeout handling: after timeout it emits Event::MessageTimeout and a Finalized signal over an unbounded tokio::mpsc sender, then exits; tokio is added as a crate dependency to support this async runtime/timers.

Written by Cursor Bugbot for commit 2dbf031. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this Jan 26, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review January 26, 2026 14:12
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama resolved 1 discussion.
Reviewable status: 3 of 4 files reviewed, 9 unresolved discussions (waiting on guy-starkware, noamsp-starkware, and sirandreww-starkware).

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama resolved 1 discussion.
Reviewable status: 3 of 4 files reviewed, 8 unresolved discussions (waiting on guy-starkware, noamsp-starkware, and sirandreww-starkware).

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama resolved 1 discussion.
Reviewable status: 3 of 4 files reviewed, 7 unresolved discussions (waiting on guy-starkware, noamsp-starkware, and sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 01-26-apollo_propeller_add_messageprocessor_scaffolding branch from db030c5 to bc26e1d Compare February 19, 2026 10:16
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/12003 to apollo_propeller_added_shard_index_utility_functions_to_schedule_manager February 19, 2026 10:17
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 10 comments and resolved 1 discussion.
Reviewable status: 2 of 4 files reviewed, 6 unresolved discussions (waiting on guy-starkware, noamsp-starkware, and ShahakShama).


crates/apollo_propeller/src/message_processor.rs line 4 at r1 (raw file):

Previously, ShahakShama wrote…

To make it clear, Andrew please rephrase this at a way that's easier to understand

Removed


crates/apollo_propeller/src/message_processor.rs line 41 at r1 (raw file):

Previously, ShahakShama wrote…

+1. Also, publisher public key is message identification IIUC
Let's just remove these comments

Done


crates/apollo_propeller/src/message_processor.rs line 24 at r2 (raw file):

Previously, ShahakShama wrote…

Rename to EventStateManagerToEngine or CommandStateManagerToEngine to make its meaning more clear (and then you can remove the comment above)
If you chose event, rename the Event variant to BehaviourEvent or ExternalEvent

Done


crates/apollo_propeller/src/message_processor.rs line 47 at r2 (raw file):

Previously, ShahakShama wrote…

Make these bounded. TODO is fine for now

Added a comment why this needs to be unbounded


crates/apollo_propeller/src/message_processor.rs line 51 at r2 (raw file):

Previously, ShahakShama wrote…

Rename to describe what this does better

Agreed in meeting not to do this


crates/apollo_propeller/src/message_processor.rs line 56 at r2 (raw file):

Previously, ShahakShama wrote…

I think this can be debug

Done


crates/apollo_propeller/src/message_processor.rs line 56 at r2 (raw file):

Previously, ShahakShama wrote…

Add a use statement instead (should've probably wrote this in previous PRs)

Done


crates/apollo_propeller/src/message_processor.rs line 67 at r2 (raw file):

Previously, ShahakShama wrote…

Explain why you need this, both to me and in the TODO

will be removed in future PRs


crates/apollo_propeller/src/message_processor.rs line 70 at r3 (raw file):

Previously, ShahakShama wrote…

use tokio::timeout instead

I don't want to restructure the loop, timeout takes a future and runs it with a timeout.
there's also tokio::sleep, but I'm worried that if I give it a duration rather than an instance the duration will reset on the next iteration of the loop


crates/apollo_propeller/src/message_processor.rs line 70 at r3 (raw file):

Previously, ShahakShama wrote…

Add TODO to run the logic

Not necessary, next PR fixes this

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 2 files and all commit messages, made 1 comment, and resolved 6 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on guy-starkware and noamsp-starkware).

Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 01-26-apollo_propeller_add_messageprocessor_scaffolding branch from bc26e1d to 5805542 Compare February 19, 2026 15:36
@sirandreww-starkware sirandreww-starkware force-pushed the apollo_propeller_added_shard_index_utility_functions_to_schedule_manager branch from a22c082 to 4b0f6f9 Compare February 19, 2026 15:36
@sirandreww-starkware sirandreww-starkware force-pushed the 01-26-apollo_propeller_add_messageprocessor_scaffolding branch from 5805542 to f15b95a Compare February 19, 2026 16:02
@sirandreww-starkware sirandreww-starkware force-pushed the apollo_propeller_added_shard_index_utility_functions_to_schedule_manager branch from 3130129 to 476cbae Compare February 22, 2026 07:37
@sirandreww-starkware sirandreww-starkware force-pushed the 01-26-apollo_propeller_add_messageprocessor_scaffolding branch 2 times, most recently from 6a30d55 to 0862594 Compare February 22, 2026 09:15
@sirandreww-starkware sirandreww-starkware force-pushed the apollo_propeller_added_shard_index_utility_functions_to_schedule_manager branch 2 times, most recently from 05a0515 to 3e54bba Compare February 22, 2026 13:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-26-apollo_propeller_add_messageprocessor_scaffolding branch from 0862594 to 5428236 Compare February 22, 2026 13:24
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the apollo_propeller_added_shard_index_utility_functions_to_schedule_manager branch from 3e54bba to aab26f0 Compare February 22, 2026 13:53
@sirandreww-starkware sirandreww-starkware force-pushed the 01-26-apollo_propeller_add_messageprocessor_scaffolding branch from 5428236 to 6ee3b2a Compare February 22, 2026 13:53
@sirandreww-starkware sirandreww-starkware changed the base branch from apollo_propeller_added_shard_index_utility_functions_to_schedule_manager to main-v0.14.2 February 22, 2026 14:10
@sirandreww-starkware sirandreww-starkware force-pushed the 01-26-apollo_propeller_add_messageprocessor_scaffolding branch from 6ee3b2a to 2dbf031 Compare February 22, 2026 14:21
@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Feb 22, 2026
Merged via the queue into main-v0.14.2 with commit fafe1a0 Feb 22, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants