Skip to content

starknet_os: test that the most recent virtual os program hash is allowed#12091

Merged
meship-starkware merged 1 commit intomain-v0.14.2from
meship/test_that_the_most_recent_virtual_os_progarm_hash_is_allowed
Jan 29, 2026
Merged

starknet_os: test that the most recent virtual os program hash is allowed#12091
meship-starkware merged 1 commit intomain-v0.14.2from
meship/test_that_the_most_recent_virtual_os_progarm_hash_is_allowed

Conversation

@meship-starkware
Copy link
Collaborator

allowed

@meship-starkware meship-starkware marked this pull request as ready for review January 28, 2026 10:24
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Copy link
Collaborator Author

meship-starkware commented Jan 28, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@meship-starkware meship-starkware changed the base branch from main to graphite-base/12091 January 28, 2026 11:16
@meship-starkware meship-starkware force-pushed the meship/test_that_the_most_recent_virtual_os_progarm_hash_is_allowed branch from f879389 to ff85295 Compare January 28, 2026 11:16
@meship-starkware meship-starkware changed the base branch from graphite-base/12091 to main-v0.14.2 January 28, 2026 11:16
@meship-starkware meship-starkware force-pushed the meship/test_that_the_most_recent_virtual_os_progarm_hash_is_allowed branch 2 times, most recently from 36a8bc9 to 1c8e48a Compare January 28, 2026 12:35
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noaov1 reviewed 11 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @meship-starkware).


crates/starknet_api/src/test_utils.rs line 233 at r1 (raw file):

// Virtual OS program hash for testing. Should match one of the allowed virtual OS program hashes in
// the current versioned constants.

Why can't it be a mock value?

Code quote:

// Virtual OS program hash for testing. Should match one of the allowed virtual OS program hashes in
// the current versioned constants.

Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1).


crates/starknet_api/src/test_utils.rs line 233 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why can't it be a mock value?

I will add a monday task so this could be a mock value

Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).

@meship-starkware meship-starkware force-pushed the meship/test_that_the_most_recent_virtual_os_progarm_hash_is_allowed branch from 1c8e48a to 39d2a2e Compare January 28, 2026 16:03
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).

@meship-starkware meship-starkware added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main-v0.14.2 with commit 08fbd24 Jan 29, 2026
31 of 33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants