starknet_os: test that the most recent virtual os program hash is allowed#12091
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f879389 to
ff85295
Compare
36a8bc9 to
1c8e48a
Compare
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 reviewed 11 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @meship-starkware).
crates/starknet_api/src/test_utils.rs line 233 at r1 (raw file):
// Virtual OS program hash for testing. Should match one of the allowed virtual OS program hashes in // the current versioned constants.
Why can't it be a mock value?
Code quote:
// Virtual OS program hash for testing. Should match one of the allowed virtual OS program hashes in
// the current versioned constants.
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1).
crates/starknet_api/src/test_utils.rs line 233 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Why can't it be a mock value?
I will add a monday task so this could be a mock value
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).
1c8e48a to
39d2a2e
Compare
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).

allowed