Ayelet/mempool/naive mempool/rebase over 14 1#12361
Closed
ayeletstarkware wants to merge 5 commits intomain-v0.14.1from
Closed
Ayelet/mempool/naive mempool/rebase over 14 1#12361ayeletstarkware wants to merge 5 commits intomain-v0.14.1from
ayeletstarkware wants to merge 5 commits intomain-v0.14.1from
Conversation
|
This change is |
ayeletstarkware
force-pushed
the
ayelet/mempool/naive-mempool/rebase-over-14-1
branch
6 times, most recently
from
3cca044 to
8bc8faf
Compare
ayeletstarkware
force-pushed
the
ayelet/mempool/naive-mempool/rebase-over-14-1
branch
from
8bc8faf to
c1d02d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes core transaction ordering and block-building behavior behind a new config flag; incorrect mode configuration or edge cases in FIFO rewind/declare handling could affect sequencing correctness.
Overview
Adds a new
DeploymentMode(defaultstarknet, newechonet) and threads it through configuration so components can switch behavior by environment.In
apollo_mempool, introduces a FIFO-backed transaction queue used inechonetmode (no fee-based prioritization and nodeclare_delay), plus a dedicated rewind implementation incommit_block; adds/adjusts unit tests and updates deployment JSON configs to set mempooldeployment_modetoechonet.In
apollo_consensus_orchestrator, adds a mode-gated path to use state-sync block timestamps when building proposals inechonet.Written by Cursor Bugbot for commit c1d02d2. This will update automatically on new commits. Configure here.