apollo_mempool: Try to fix the mempool syncronization#12372
Closed
ron-starkware wants to merge 3 commits intoayelet/mempool/naive-mempool/rebase-over-14-1-get_tsfrom
Closed
apollo_mempool: Try to fix the mempool syncronization#12372ron-starkware wants to merge 3 commits intoayelet/mempool/naive-mempool/rebase-over-14-1-get_tsfrom
ron-starkware wants to merge 3 commits intoayelet/mempool/naive-mempool/rebase-over-14-1-get_tsfrom
Conversation
|
Artifacts upload workflows: |
| fn front_tx_hash(&self) -> Option<TransactionHash> { | ||
| None | ||
| } | ||
|
|
There was a problem hiding this comment.
Unused trait methods left as dead code
Low Severity
The trait methods get_first_tx_timestamp and set_last_returned_timestamp are now dead code. This PR removed the implementations from FifoTransactionQueue and removed all callers (previously in Mempool::get_ts), but the trait methods themselves remain. FeeTransactionQueue uses the default implementations (which return None and do nothing), and no code calls these methods anymore. These orphaned trait methods add confusion for future developers.
50cb3ca to
8dcc1c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Changes how block timestamps are produced in Echonet and introduces an async network dependency on the
GetTimestamprequest path; incorrect recorder responses or edge cases could affect timestamp consistency, though failures now safely fall back to local time.Overview
In Echonet mode, timestamp handling is reworked so the FIFO queue no longer performs blocking HTTP calls or timestamp-based filtering;
pop_ready_chunknow returns transactions purely in FIFO order.GetTimestampis changed to be async and, for Echonet only, fetches the front transaction’s timestamp from the recorder via a bounded (2s)reqwestcall, caching by front tx hash and falling back to the local clock on failure. The mempool exposesfront_tx_hash,recorder_url, andis_echonetto support this.Tests are simplified by removing
mockitousage and timestamp-related FIFO tests, and dependencies are updated to dropreqwestblocking +mockitofrom the crate/dev setup.Written by Cursor Bugbot for commit 982c7ff. This will update automatically on new commits. Configure here.