Skip to content

starknet_os_runner: allow fee token address overide#12533

Merged
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/allow_fee_token_address_ovveride
Feb 14, 2026
Merged

starknet_os_runner: allow fee token address overide#12533
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/allow_fee_token_address_ovveride

Conversation

@AvivYossef-starkware
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware commented Feb 12, 2026

Note

Medium Risk
Touches fee token address selection used in BlockContext, which can affect fee-related execution and OS inputs if misconfigured; change is mostly plumbing with safe default (None).

Overview
Adds an optional strk_fee_token_address override that flows from starknet_os_runner config/CLI into RPC execution components, allowing custom environments sharing a ChainId to use a non-default STRK fee token contract.

This threads the override through RpcRunnerFactory, RpcVirtualBlockExecutor, and blockifier_reexecution::RpcStateReader, and updates get_chain_info/get_fee_token_addresses to accept the override when building BlockContext. Tests/fixtures are updated to include the new field/parameter (defaulting to None).

Written by Cursor Bugbot for commit 94d00dd. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review February 12, 2026 12:41
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/allow_fee_token_address_ovveride branch from 7651a81 to 23e2707 Compare February 12, 2026 14:29
Copy link
Contributor

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@einat-starkware partially reviewed 10 files and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @meship-starkware and @noaov1).

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/allow_fee_token_address_ovveride branch 2 times, most recently from 23751e4 to 2b444a1 Compare February 14, 2026 15:05
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware and @noaov1).

Co-authored-by: Cursor <cursoragent@cursor.com>
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/allow_fee_token_address_ovveride branch from 2b444a1 to 94d00dd Compare February 14, 2026 15:26
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware and @noaov1).

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Feb 14, 2026
Merged via the queue into main-v0.14.2 with commit 75abb8f Feb 14, 2026
21 of 25 checks passed
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 partially reviewed 11 files and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions.


a discussion (no related file):
It feels a bit of a code duplication. Can the chain info be computed once at a higher level and passed down?


crates/blockifier_reexecution/src/utils.rs line 74 at r1 (raw file):

/// Returns the chain info for the given chain.
/// If `strk_fee_token_address_override` is provided, it overrides the default STRK fee token
/// address.

crates/starknet_os_runner/src/config.rs line 15 at r1 (raw file):

    /// Configuration for the contract class manager.
    pub contract_class_manager_config: ContractClassManagerConfig,
    /// Chain ID for transaction hash calculation.

Is this the only use?

Code quote:

    /// Chain ID for transaction hash calculation.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants