starknet_os_runner: allow fee token address overide#12533
starknet_os_runner: allow fee token address overide#12533AvivYossef-starkware merged 1 commit intomain-v0.14.2from
Conversation
7651a81 to
23e2707
Compare
einat-starkware
left a comment
There was a problem hiding this comment.
@einat-starkware partially reviewed 10 files and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @meship-starkware and @noaov1).
23751e4 to
2b444a1
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
@AvivYossef-starkware reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware and @noaov1).
Co-authored-by: Cursor <cursoragent@cursor.com>
2b444a1 to
94d00dd
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
@AvivYossef-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware and @noaov1).
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 partially reviewed 11 files and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions.
a discussion (no related file):
It feels a bit of a code duplication. Can the chain info be computed once at a higher level and passed down?
crates/blockifier_reexecution/src/utils.rs line 74 at r1 (raw file):
/// Returns the chain info for the given chain. /// If `strk_fee_token_address_override` is provided, it overrides the default STRK fee token /// address.
crates/starknet_os_runner/src/config.rs line 15 at r1 (raw file):
/// Configuration for the contract class manager. pub contract_class_manager_config: ContractClassManagerConfig, /// Chain ID for transaction hash calculation.
Is this the only use?
Code quote:
/// Chain ID for transaction hash calculation.
Note
Medium Risk
Touches fee token address selection used in
BlockContext, which can affect fee-related execution and OS inputs if misconfigured; change is mostly plumbing with safe default (None).Overview
Adds an optional
strk_fee_token_addressoverride that flows fromstarknet_os_runnerconfig/CLI into RPC execution components, allowing custom environments sharing aChainIdto use a non-default STRK fee token contract.This threads the override through
RpcRunnerFactory,RpcVirtualBlockExecutor, andblockifier_reexecution::RpcStateReader, and updatesget_chain_info/get_fee_token_addressesto accept the override when buildingBlockContext. Tests/fixtures are updated to include the new field/parameter (defaulting toNone).Written by Cursor Bugbot for commit 94d00dd. This will update automatically on new commits. Configure here.