workspace: fix documentation typos, grammar, and correctness issues#12566
workspace: fix documentation typos, grammar, and correctness issues#12566dan-starkware merged 1 commit intomainfrom
Conversation
ac3ba1e to
78c580a
Compare
78c580a to
1ee406c
Compare
dafnamatsry
left a comment
There was a problem hiding this comment.
@dafnamatsry reviewed 11 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @eitanm-starkware).
crates/apollo_config/src/dumping.rs line 160 at r1 (raw file):
/// Conversion of a configuration to a mapping of flattened parameters to their descriptions and /// values. /// Note, in the case of a None sub configs, its elements will not be included in the flatten
Suggestion:
None sub configs, their1ee406c to
c569041
Compare
eitanm-starkware
left a comment
There was a problem hiding this comment.
@eitanm-starkware reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware).
dan-starkware
left a comment
There was a problem hiding this comment.
@dan-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry).
crates/apollo_config/src/dumping.rs line 160 at r1 (raw file):
/// Conversion of a configuration to a mapping of flattened parameters to their descriptions and /// values. /// Note, in the case of a None sub configs, its elements will not be included in the flatten
Done.
dafnamatsry
left a comment
There was a problem hiding this comment.
@dafnamatsry reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dan-starkware).
No description provided.