Skip to content

workspace: fix documentation typos, grammar, and correctness issues#12566

Merged
dan-starkware merged 1 commit intomainfrom
claude/fix-documentation-D5Hur
Feb 15, 2026
Merged

workspace: fix documentation typos, grammar, and correctness issues#12566
dan-starkware merged 1 commit intomainfrom
claude/fix-documentation-D5Hur

Conversation

@dan-starkware
Copy link
Collaborator

@dan-starkware dan-starkware commented Feb 13, 2026

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

@dan-starkware dan-starkware force-pushed the claude/fix-documentation-D5Hur branch from ac3ba1e to 78c580a Compare February 14, 2026 16:11
@dan-starkware dan-starkware force-pushed the claude/fix-documentation-D5Hur branch from 78c580a to 1ee406c Compare February 14, 2026 16:18
@dan-starkware dan-starkware changed the title Fix documentation typos, grammar, and correctness issues workspace: fix documentation typos, grammar, and correctness issues Feb 14, 2026
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@dafnamatsry reviewed 11 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @eitanm-starkware).


crates/apollo_config/src/dumping.rs line 160 at r1 (raw file):

    /// Conversion of a configuration to a mapping of flattened parameters to their descriptions and
    /// values.
    /// Note, in the case of a None sub configs, its elements will not be included in the flatten

Suggestion:

None sub configs, their

@dan-starkware dan-starkware removed the request for review from eitanm-starkware February 15, 2026 07:22
@dan-starkware dan-starkware force-pushed the claude/fix-documentation-D5Hur branch from 1ee406c to c569041 Compare February 15, 2026 07:25
Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@eitanm-starkware reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware).

Copy link
Collaborator Author

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry).


crates/apollo_config/src/dumping.rs line 160 at r1 (raw file):

    /// Conversion of a configuration to a mapping of flattened parameters to their descriptions and
    /// values.
    /// Note, in the case of a None sub configs, its elements will not be included in the flatten

Done.

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dafnamatsry reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware).

@dan-starkware dan-starkware added this pull request to the merge queue Feb 15, 2026
Merged via the queue into main with commit 69b4c8d Feb 15, 2026
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants