workspace: add await_holding_lock and await_holding_refcell_ref clippy lints#12567
Merged
dan-starkware merged 1 commit intomain-v0.14.2from Feb 15, 2026
Merged
workspace: add await_holding_lock and await_holding_refcell_ref clippy lints#12567dan-starkware merged 1 commit intomain-v0.14.2from
dan-starkware merged 1 commit intomain-v0.14.2from
Conversation
Add workspace-level clippy lints: - `await_holding_lock`: warns when a std::sync::Mutex (or RwLock) guard is held across an .await point, which can cause deadlocks or block the tokio runtime. - `await_holding_refcell_ref`: warns when a RefCell borrow is held across an .await point, which will panic if the future is polled from a different context. These lints pass cleanly on the existing codebase - all current std::sync::Mutex usage correctly drops guards before .await points. https://claude.ai/code/session_0133EbxcuGyrYJNCtfpKRjyR
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
dan-starkware
changed the title
dorimedini-starkware
approved these changes
Feb 15, 2026
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matanl-starkware and @ShahakShama).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.