Skip to content

apollo_consensus_orchestrator: detect panics in reproposal task #12568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dan-starkware merged 1 commit into from
Feb 15, 2026
Merged

apollo_consensus_orchestrator: detect panics in reproposal task #12568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ impl ConsensusContext for SequencerConsensusContext {

let transaction_converter = self.deps.transaction_converter.clone();
let mut stream_sender = self.start_stream(HeightAndRound(height.0, init.round)).await;
tokio::spawn(
let handle = tokio::spawn(
async move {
let res =
send_reproposal(id, block_info, txs, &mut stream_sender, transaction_converter)
Expand All @@ -644,6 +644,13 @@ impl ConsensusContext for SequencerConsensusContext {
}
.instrument(error_span!("consensus_repropose", round = init.round)),
);
// Spawn a follow-up task to detect panics. Without this, if the reproposal
// task panics, the JoinError is silently swallowed when the handle is dropped.
tokio::spawn(async move {
if let Err(e) = handle.await {
error!("Reproposal task panicked: {e:?}");
}
});
}

async fn validators(&self, _height: BlockNumber) -> Result<Vec<ValidatorId>, ConsensusError> {
Expand Down
Loading