ci: use custom yoav namespace profile#12685
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
yoavGrs
force-pushed
the
yoav/ci/caching/use_custom_namespace_profile
branch
from
c16f4df to
8ead596
Compare
yoavGrs
force-pushed
the
yoav/ci/caching/use_custom_namespace_profile
branch
3 times, most recently
from
adb2dae to
a52300b
Compare
yoavGrs
changed the base branch from
main-v0.14.1-committer
to
graphite-base/12685
yoavGrs
force-pushed
the
yoav/ci/caching/use_custom_namespace_profile
branch
from
a52300b to
7a27831
Compare
yoavGrs
force-pushed
the
graphite-base/12685
branch
from
91dfc55 to
37d6872
Compare
|
Artifacts upload workflows: |
yoavGrs
force-pushed
the
yoav/ci/caching/use_custom_namespace_profile
branch
from
7a27831 to
59dd3ca
Compare
|
|
||
| run-tests: | ||
| runs-on: namespace-profile-xlarge-ubuntu-24-04-amd64 | ||
| runs-on: namespace-profile-yoav-cache-testing-profile |
There was a problem hiding this comment.
Personal testing CI runner profile committed to production workflows
High Severity
The standard namespace-profile-xlarge-ubuntu-24-04-amd64 runner is replaced with namespace-profile-yoav-cache-testing-profile, a personal testing profile. This affects the run-tests job in main.yml and the benchmarking job in blockifier_ci.yml. Benchmarking results are especially sensitive to runner specs — using a non-standard profile could produce misleading performance comparisons and regressions/improvements that don't reflect reality. If this profile is later removed or has different resources, CI will break.
Additional Locations (1)
yoavGrs
force-pushed
the
yoav/ci/caching/use_custom_namespace_profile
branch
from
59dd3ca to
1c31fc2
Compare
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on yoavGrs).
.github/workflows/blockifier_ci.yml line 84 at r3 (raw file):
benchmarking: runs-on: namespace-profile-yoav-cache-testing-profile
Why is there a public runner named after an employee?
Code quote:
namespace-profile-yoav-cache-testing-profile
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 1 comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on Itay-Tsabary-Starkware).
.github/workflows/blockifier_ci.yml line 84 at r3 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Why is there a public runner named after an employee?
It's not going to be merged, just for testing the CI with a separate disc in the following PRs.
3 participants
Note
Low Risk
Workflow-only change that just alters the GitHub Actions runner profile; main risk is CI performance/availability differences on the new runner.
Overview
CI runner selection is updated to use the custom
namespace-profile-yoav-cache-testing-profilefor the heaviest jobs.Specifically,
main.ymlswitches therun-testsjob runner, andblockifier_ci.ymlswitches the PR-onlybenchmarkingjob runner, leaving the job steps and commands unchanged.Written by Cursor Bugbot for commit 1c31fc2. This will update automatically on new commits. Configure here.