apollo_transaction_converter: align proving deps with stwo 1.0.1#12707
apollo_transaction_converter: align proving deps with stwo 1.0.1#12707avi-starkware wants to merge 2 commits intomain-v0.14.2from
Conversation
10ba7a0 to
39fd2b2
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 of 13 files reviewed, 1 unresolved discussion (waiting on avi-starkware, einat-starkware, and noaov1).
crates/apollo_compile_to_casm_types/src/test.rs line 27 at r1 (raw file):
const EXPECTED: &str = "{\"V1\":[{\"prime\":\"0x0\",\"compiler_version\":\"\",\"bytecode\":[\"\ 0x1\",\"0x1\",\"0x1\"],\"hints\":[],\"entry_points_by_type\":{\"\ EXTERNAL\":[],\"L1_HANDLER\":[],\"CONSTRUCTOR\":[]}},\"1.7.0\"]}";
Ho not again. I fixed this a few fix ago
Code quote:
const EXPECTED: &str = "{\"V1\":[{\"prime\":\"0x0\",\"compiler_version\":\"\",\"bytecode\":[\"\
0x1\",\"0x1\",\"0x1\"],\"hints\":[],\"entry_points_by_type\":{\"\
EXTERNAL\":[],\"L1_HANDLER\":[],\"CONSTRUCTOR\":[]}},\"1.7.0\"]}";
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware made 1 comment.
Reviewable status: 1 of 13 files reviewed, 1 unresolved discussion (waiting on avi-starkware, einat-starkware, and noaov1).
crates/apollo_compile_to_casm_types/src/test.rs line 27 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Ho not again. I fixed this a few fix ago
There's an unnecessary feature that propagates from one of the new deps. TAL
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware made 1 comment.
Reviewable status: 1 of 13 files reviewed, 1 unresolved discussion (waiting on avi-starkware, einat-starkware, and noaov1).
crates/apollo_compile_to_casm_types/src/test.rs line 27 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
There's an unnecessary feature that propagates from one of the new deps. TAL
"preserve_order"
39fd2b2 to
3ee787c
Compare
|
Previously, Yoni-Starkware (Yoni) wrote…
fixed (using stwo crates at |
|
I had to use tomer's branch instead of a stable version since there is no published version of cairo_native which supports cairo-lang Note that tomer's branch still does not pass lambdaclass's ci Code quote: cairo-native = { git = "https://github.com/lambdaclass/cairo_native", branch = "tomer/blake_builtin" } |
…shed 1.1.0 releases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3ee787c to
0cb054c
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 14 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on einat-starkware and noaov1).
…6 and cairo-native Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
cairo-airfrom git rev to published 1.0.1,stwofrom git rev to 2.0.1.cairo-program-runner-lib,stwo-cairo-adapter,stwo-cairo-prover, andstwo-run-and-prove(consumed in later PRs).proof_verification.rsto the simplifiedverify_cairoAPI (CairoProofForRustVerifierreplacesCairoProofSorted+PreProcessedTraceVariant).Stack: 1/4 — this PR isolates the global dependency/API migration from runner behavior changes.
Test plan
cargo test -p apollo_transaction_convertercargo clippy -p apollo_transaction_converter --all-targets --all-features🤖 Generated with Claude Code
Note
Medium Risk
Touches proof verification and core proving dependencies; while mostly dependency/API alignment, any mismatch in proof encoding/verification or Cairo compiler behavior could break verification at runtime.
Overview
Updates proving/verification dependencies by moving
cairo-airandstwofrom pinned git revs to crates.io releases, bumping Cairo compiler crates to2.16.0, and adding new workspace deps (cairo-program-runner-lib,stwo-cairo-*,stwo-run-and-prove).cairo-nativeis switched to a specific git branch.Adapts
apollo_transaction_converterproof verification to the newcairo-airAPI by deserializingCairoProofForRustVerifierdirectly and calling the simplifiedverify_cairowithoutPreProcessedTraceVariant/conversion. Aligns compilation tooling/tests with updated audited libfuncs (adds blake/gas/boxing-related libfuncs, updates audited-libfunc alignment test), wires the newblakebuiltin gas cost into native execution, refreshes native test compilation helpers, and updates snapshots/example proof facts plus the pinnedproving-utilsrevision.Written by Cursor Bugbot for commit fa0d50b. This will update automatically on new commits. Configure here.