Skip to content

Comments

starknet_os_runner,ci,scripts: nightly/toolchain + docker + focused workflow#12710

Open
avi-starkware wants to merge 1 commit intoavi/privacy/prove-cairopie-in-memoryfrom
avi/privacy/nightly-toolchain-docker-ci
Open

starknet_os_runner,ci,scripts: nightly/toolchain + docker + focused workflow#12710
avi-starkware wants to merge 1 commit intoavi/privacy/prove-cairopie-in-memoryfrom
avi/privacy/nightly-toolchain-docker-ci

Conversation

@avi-starkware
Copy link
Collaborator

@avi-starkware avi-starkware commented Feb 18, 2026

Summary

  • Add starknet_os_runner_ci.yml workflow running tests with stwo_proving feature on nightly.
  • Add crate-level rust-toolchain.toml pinning nightly-2025-07-14.
  • Simplify Dockerfile: remove the separate proving-utils builder stage and PROVING_UTILS_DIR build arg.
  • Simplify build_starknet_os_runner.sh: remove proving-utils clone step and related CLI flags.
  • Update proving_utils_env.sh default rev to 316344a.

Stack: 4/4 — infra-only PR after functionality is already merged.

Depends on: #12709

Test plan

  • New CI workflow triggers on path changes and passes.
  • docker build -f crates/starknet_os_runner/Dockerfile -t os_runner:latest . (optional local smoke test)

🤖 Generated with Claude Code


Note

Medium Risk
Build/CI infrastructure changes (pinned nightly toolchain, new workflow triggers, and Docker build restructuring) could break runner builds or CI if the toolchain/date pin or build assumptions are incorrect.

Overview
Adds a new Starknet-OS-Runner-CI GitHub Actions workflow that runs cargo test for starknet_os_runner with --features stwo_proving on PRs affecting the runner/OS/proving utils, including PyPy setup and strict RUSTFLAGS=-D warnings.

Pins crates/starknet_os_runner to nightly-2025-07-14 via a new rust-toolchain.toml, and updates the runner Docker build to always use that nightly (including cargo-chef), while removing the separate proving-utils planner/builder stages and PROVING_UTILS_DIR build arg.

Simplifies scripts/build_starknet_os_runner.sh by removing proving-utils cloning/revision override support and building the Docker image directly from the repo root with only BUILD_MODE and optional extra docker args.

Written by Cursor Bugbot for commit d45767e. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@avi-starkware avi-starkware force-pushed the avi/privacy/nightly-toolchain-docker-ci branch from d6e41ba to 7e3e053 Compare February 18, 2026 19:05
@avi-starkware avi-starkware force-pushed the avi/privacy/prove-cairopie-in-memory branch from 371dca2 to 9905d53 Compare February 18, 2026 19:05
@avi-starkware avi-starkware force-pushed the avi/privacy/prove-cairopie-in-memory branch from 9905d53 to 25ae321 Compare February 18, 2026 20:55
@avi-starkware avi-starkware requested a review from a team as a code owner February 18, 2026 20:55
@avi-starkware avi-starkware force-pushed the avi/privacy/nightly-toolchain-docker-ci branch 2 times, most recently from e394d27 to b0648d8 Compare February 18, 2026 21:16
@avi-starkware avi-starkware force-pushed the avi/privacy/prove-cairopie-in-memory branch 2 times, most recently from 1549f14 to c5adae0 Compare February 18, 2026 21:23
@avi-starkware avi-starkware force-pushed the avi/privacy/nightly-toolchain-docker-ci branch from b0648d8 to a6b2c7e Compare February 18, 2026 21:23
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@avi-starkware avi-starkware force-pushed the avi/privacy/prove-cairopie-in-memory branch from c5adae0 to 2fb5f63 Compare February 22, 2026 15:15
@avi-starkware avi-starkware force-pushed the avi/privacy/nightly-toolchain-docker-ci branch from a6b2c7e to a843652 Compare February 22, 2026 15:15
@avi-starkware avi-starkware force-pushed the avi/privacy/prove-cairopie-in-memory branch from 2fb5f63 to 88d7b14 Compare February 22, 2026 15:38
@avi-starkware avi-starkware force-pushed the avi/privacy/nightly-toolchain-docker-ci branch from a843652 to cf4fd95 Compare February 22, 2026 15:38
@avi-starkware avi-starkware force-pushed the avi/privacy/prove-cairopie-in-memory branch from 88d7b14 to abf0d3c Compare February 22, 2026 16:08
@avi-starkware avi-starkware force-pushed the avi/privacy/nightly-toolchain-docker-ci branch from cf4fd95 to 46936d4 Compare February 22, 2026 16:08
@avi-starkware avi-starkware force-pushed the avi/privacy/prove-cairopie-in-memory branch from abf0d3c to 73bc9ab Compare February 22, 2026 16:51
…orkflow

Add CI workflow, pin the nightly toolchain, and simplify the Docker build
now that stwo proving is an in-memory library dependency.

Changes:
- Add starknet_os_runner_ci.yml workflow running tests with stwo_proving
  feature on nightly.
- Add crate-level rust-toolchain.toml pinning nightly-2025-07-14.
- Simplify Dockerfile: remove the separate proving-utils builder stage
  and the PROVING_UTILS_DIR build arg; build with nightly.
- Simplify build_starknet_os_runner.sh: remove proving-utils clone step
  and related CLI flags.
- Update proving_utils_env.sh default rev to 316344a.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@avi-starkware avi-starkware force-pushed the avi/privacy/nightly-toolchain-docker-ci branch from 46936d4 to d45767e Compare February 22, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants