starknet_os_runner,ci,scripts: nightly/toolchain + docker + focused workflow#12710
Open
avi-starkware wants to merge 1 commit intoavi/privacy/prove-cairopie-in-memoryfrom
Open
Conversation
d6e41ba to
7e3e053
Compare
371dca2 to
9905d53
Compare
9905d53 to
25ae321
Compare
e394d27 to
b0648d8
Compare
1549f14 to
c5adae0
Compare
b0648d8 to
a6b2c7e
Compare
c5adae0 to
2fb5f63
Compare
a6b2c7e to
a843652
Compare
2fb5f63 to
88d7b14
Compare
a843652 to
cf4fd95
Compare
88d7b14 to
abf0d3c
Compare
cf4fd95 to
46936d4
Compare
abf0d3c to
73bc9ab
Compare
…orkflow Add CI workflow, pin the nightly toolchain, and simplify the Docker build now that stwo proving is an in-memory library dependency. Changes: - Add starknet_os_runner_ci.yml workflow running tests with stwo_proving feature on nightly. - Add crate-level rust-toolchain.toml pinning nightly-2025-07-14. - Simplify Dockerfile: remove the separate proving-utils builder stage and the PROVING_UTILS_DIR build arg; build with nightly. - Simplify build_starknet_os_runner.sh: remove proving-utils clone step and related CLI flags. - Update proving_utils_env.sh default rev to 316344a. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
46936d4 to
d45767e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starknet_os_runner_ci.ymlworkflow running tests withstwo_provingfeature on nightly.rust-toolchain.tomlpinningnightly-2025-07-14.PROVING_UTILS_DIRbuild arg.build_starknet_os_runner.sh: remove proving-utils clone step and related CLI flags.proving_utils_env.shdefault rev to316344a.Stack: 4/4 — infra-only PR after functionality is already merged.
Depends on: #12709
Test plan
docker build -f crates/starknet_os_runner/Dockerfile -t os_runner:latest .(optional local smoke test)🤖 Generated with Claude Code
Note
Medium Risk
Build/CI infrastructure changes (pinned nightly toolchain, new workflow triggers, and Docker build restructuring) could break runner builds or CI if the toolchain/date pin or build assumptions are incorrect.
Overview
Adds a new
Starknet-OS-Runner-CIGitHub Actions workflow that runscargo testforstarknet_os_runnerwith--features stwo_provingon PRs affecting the runner/OS/proving utils, including PyPy setup and strictRUSTFLAGS=-D warnings.Pins
crates/starknet_os_runnertonightly-2025-07-14via a newrust-toolchain.toml, and updates the runner Docker build to always use that nightly (includingcargo-chef), while removing the separate proving-utils planner/builder stages andPROVING_UTILS_DIRbuild arg.Simplifies
scripts/build_starknet_os_runner.shby removing proving-utils cloning/revision override support and building the Docker image directly from the repo root with onlyBUILD_MODEand optional extra docker args.Written by Cursor Bugbot for commit d45767e. This will update automatically on new commits. Configure here.