apollo_http_server: conditionaly add the tx to the instrument print#12788
Open
ArniStarkware wants to merge 1 commit intoarni/http_server/instrument_on_add_txfrom
Open
Conversation
|
This change is |
|
Artifacts upload workflows: |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ArniStarkware
force-pushed
the
arni/http_server/instrument_add_tx_print_if_in_length_range
branch
from
794c8eb to
5e04975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Logging-only changes plus new helper methods; low chance of affecting transaction processing, but verify the new thresholds don’t hinder debugging for legitimate large transactions.
Overview
Reduces log/trace verbosity for incoming transactions by conditionally including the full transaction payload in
#[instrument]span fields.For
/gateway/add_rpc_transaction, it now logstxonly whensignature_len <= 2andcalldata_len <= 100, otherwise records a placeholder string;/gateway/add_transactionsimilarly skips logging when the raw payload exceeds 2000 bytes. This introduces lightweight helpers onRpcTransaction(and subtypes) to compute signature/calldata lengths to support the new gating logic.Written by Cursor Bugbot for commit 5e04975. This will update automatically on new commits. Configure here.