Skip to content

deployment: adds workflow which injects a check-box to PR description case of changes in services.rs#12948

Open
idan-starkware wants to merge 1 commit intomain-v0.14.2from
idan/main-v0.14.2/sequencer_config_sync_check
Open

deployment: adds workflow which injects a check-box to PR description case of changes in services.rs#12948
idan-starkware wants to merge 1 commit intomain-v0.14.2from
idan/main-v0.14.2/sequencer_config_sync_check

Conversation

@idan-starkware
Copy link
Contributor

@idan-starkware idan-starkware commented Mar 2, 2026


⚠️ Cross-Repo Sync Required

  • I have synced these changes to Private Repo Y
    The private repo Y depends on these config changes.

Note

Medium Risk
Adds a GitHub Actions workflow that modifies PR bodies and gates merges via a required checkbox, which can affect developer workflow and relies on pull-requests: write permissions.

Overview
Adds a new GitHub Actions workflow (.github/workflows/sync_check.yaml) that triggers on PRs touching crates/apollo_deployments/src/service.rs (or the workflow itself) and enforces a cross-repo sync confirmation.

The job fetches the latest PR body, appends a “synced to Private Repo Y” checkbox section if missing, and fails the check until the checkbox is marked as checked.

Written by Cursor Bugbot for commit cf077d4. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@idan-starkware idan-starkware marked this pull request as ready for review March 2, 2026 10:47
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

with:
script: |
const checkbox = "- [ ] I have synced these changes to **Private Repo Y**";
const checked = "- [x] I have synced these changes to **Private Repo Y**";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder "Private Repo Y" not replaced with actual name

High Severity

The strings "Private Repo Y" throughout this workflow appear to be template placeholders that were never replaced with the actual private repository name. The checkbox text, error messages, and descriptive note all reference this generic name. This will be shown to developers in their PR descriptions and CI failure messages, making it unclear which repository actually needs syncing.

Additional Locations (2)

Fix in Cursor Fix in Web

types: [opened, synchronize, edited]
paths:
- "crates/apollo_deployments/src/service.rs"
- ".github/workflows/sync_check.yaml"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths filter ineffective for PR edited events

Medium Severity

The paths filter is not reliably enforced for pull_request edited events. When anyone edits any PR's body or title, the workflow may fire regardless of whether the PR touches service.rs. This can inject the sync checkbox into unrelated PRs and fail their checks unexpectedly.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants