Skip to content

blockifier_test_utils: remove committed Cairo 1 compiled artifacts#13106

Merged
Yoni-Starkware merged 2 commits intomain-v0.14.2from
yonatan/cairo1-on-demand-compilation
Mar 11, 2026
Merged

blockifier_test_utils: remove committed Cairo 1 compiled artifacts#13106
Yoni-Starkware merged 2 commits intomain-v0.14.2from
yonatan/cairo1-on-demand-compilation

Conversation

@Yoni-Starkware
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware commented Mar 9, 2026

Summary

  • Delete 32 generated JSON files (~164K lines) from feature_contracts/cairo1/compiled/ and feature_contracts/cairo1/sierra/
  • Add .gitignore entries to prevent re-committing Cairo 1 artifacts
  • Remove Cairo 1 -diff entries from .gitattributes (no longer needed)

This is part 3/3 of the Cairo 1 on-demand compilation stack. After PR 2, these files are unused — this PR is pure cleanup.

Test plan

  • git grep confirms no remaining references to the deleted file paths
  • All tests pass (artifacts are generated on-demand by the compilation cache)

Made with Cursor


Note

Low Risk
Low risk cleanup: removes generated Cairo 1 JSON artifacts and updates ignore/diff settings; runtime behavior should be unchanged as artifacts are now generated on-demand.

Overview
Removes previously committed Cairo 1 generated artifacts (.casm.json and .sierra.json) from blockifier_test_utils feature contract resources, leaving only directory placeholders.

Updates repo hygiene so these artifacts are no longer treated specially in diffs and cannot be re-committed: drops the Cairo 1 -diff rules from .gitattributes and adds .gitignore entries for the Cairo 1 compiled/ and sierra/ JSON outputs.

Written by Cursor Bugbot for commit de063fc. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from 57fe3df to 8e895d2 Compare March 10, 2026 06:41
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch 2 times, most recently from fdcfa11 to bb8bc52 Compare March 10, 2026 06:49
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from 8e895d2 to 2de3d48 Compare March 10, 2026 06:49
@Yoni-Starkware Yoni-Starkware changed the title chore: remove committed Cairo 1 compiled artifacts from git blockifier_test_utils: remove committed Cairo 1 compiled artifacts Mar 10, 2026
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from 2de3d48 to 36fbf51 Compare March 10, 2026 07:03
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from bb8bc52 to 283c6bc Compare March 10, 2026 07:03
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from 36fbf51 to 9317cd2 Compare March 10, 2026 07:04
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch 2 times, most recently from 3f24d9b to 5253563 Compare March 10, 2026 07:10
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch 2 times, most recently from 8c3f8a6 to ae34fb3 Compare March 10, 2026 07:52
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from 5253563 to 3d65763 Compare March 10, 2026 07:53
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from ae34fb3 to 11d10bf Compare March 10, 2026 08:09
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from 3d65763 to 607bd65 Compare March 10, 2026 08:10
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from fe96af8 to 19a3e22 Compare March 10, 2026 09:25
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from 607bd65 to adb197b Compare March 10, 2026 09:29
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from 19a3e22 to 2a16eca Compare March 10, 2026 13:29
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from adb197b to 0a36114 Compare March 10, 2026 13:29
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 36 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).


.gitignore line 60 at r1 (raw file):

# Cairo 1 compiled artifacts (generated on-demand, cached in target/).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/compiled/*.json
crates/blockifier_test_utils/resources/feature_contracts/cairo1/sierra/*.json

non-blocking

Suggestion:

# Cairo 1 compiled artifacts (deprecated, generated on-demand, cached in target/).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/compiled/*.json
crates/blockifier_test_utils/resources/feature_contracts/cairo1/sierra/*.json

@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from 2a16eca to 23c1729 Compare March 10, 2026 14:00
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from 0a36114 to 4d5e3df Compare March 10, 2026 14:01
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch 2 times, most recently from ce797d2 to c26200e Compare March 10, 2026 14:14
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from 4d5e3df to f56d76a Compare March 10, 2026 14:15
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from c26200e to ae2e866 Compare March 10, 2026 14:49
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from f56d76a to 3d91d9d Compare March 10, 2026 15:00
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).

@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from ae2e866 to c18aebb Compare March 10, 2026 16:06
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from 3d91d9d to 96a0324 Compare March 10, 2026 16:07
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch from c18aebb to 6d1fd51 Compare March 10, 2026 17:09
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from 96a0324 to 07763ec Compare March 10, 2026 17:19
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-wiring branch 2 times, most recently from 6e6c838 to cdae4e8 Compare March 10, 2026 17:26
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch 2 times, most recently from 1a0ec39 to ae55985 Compare March 11, 2026 11:22
@github-actions
Copy link

Artifacts upload workflows:

@Yoni-Starkware Yoni-Starkware changed the base branch from yonatan/cairo1-on-demand-wiring to main-v0.14.2 March 11, 2026 11:23
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 36 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@Yoni-Starkware Yoni-Starkware self-assigned this Mar 11, 2026
@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from ae55985 to d41e85b Compare March 11, 2026 11:46
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 8 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@Yoni-Starkware Yoni-Starkware force-pushed the yonatan/cairo1-on-demand-compilation branch from d41e85b to ecdb297 Compare March 11, 2026 12:30
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

…fore compilation

The starknet-compile binary is invoked from a different working
directory, so relative ListFile paths like
`./resources/experimental_libfuncs.json` must be joined with the
crate root to produce an absolute path.

Made-with: Cursor
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue Mar 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2026
@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main-v0.14.2 with commit b3d0959 Mar 11, 2026
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants