blockifier_test_utils: remove committed Cairo 1 compiled artifacts#13106
blockifier_test_utils: remove committed Cairo 1 compiled artifacts#13106Yoni-Starkware merged 2 commits intomain-v0.14.2from
Conversation
57fe3df to
8e895d2
Compare
fdcfa11 to
bb8bc52
Compare
8e895d2 to
2de3d48
Compare
2de3d48 to
36fbf51
Compare
bb8bc52 to
283c6bc
Compare
36fbf51 to
9317cd2
Compare
3f24d9b to
5253563
Compare
8c3f8a6 to
ae34fb3
Compare
5253563 to
3d65763
Compare
ae34fb3 to
11d10bf
Compare
3d65763 to
607bd65
Compare
fe96af8 to
19a3e22
Compare
607bd65 to
adb197b
Compare
19a3e22 to
2a16eca
Compare
adb197b to
0a36114
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 36 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).
.gitignore line 60 at r1 (raw file):
# Cairo 1 compiled artifacts (generated on-demand, cached in target/). crates/blockifier_test_utils/resources/feature_contracts/cairo1/compiled/*.json crates/blockifier_test_utils/resources/feature_contracts/cairo1/sierra/*.json
non-blocking
Suggestion:
# Cairo 1 compiled artifacts (deprecated, generated on-demand, cached in target/).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/compiled/*.json
crates/blockifier_test_utils/resources/feature_contracts/cairo1/sierra/*.json2a16eca to
23c1729
Compare
0a36114 to
4d5e3df
Compare
ce797d2 to
c26200e
Compare
4d5e3df to
f56d76a
Compare
c26200e to
ae2e866
Compare
f56d76a to
3d91d9d
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).
ae2e866 to
c18aebb
Compare
3d91d9d to
96a0324
Compare
c18aebb to
6d1fd51
Compare
96a0324 to
07763ec
Compare
6e6c838 to
cdae4e8
Compare
1a0ec39 to
ae55985
Compare
|
Artifacts upload workflows: |
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 36 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
ae55985 to
d41e85b
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
Made-with: Cursor
d41e85b to
ecdb297
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
…fore compilation The starknet-compile binary is invoked from a different working directory, so relative ListFile paths like `./resources/experimental_libfuncs.json` must be joined with the crate root to produce an absolute path. Made-with: Cursor
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
Summary
feature_contracts/cairo1/compiled/andfeature_contracts/cairo1/sierra/.gitignoreentries to prevent re-committing Cairo 1 artifacts-diffentries from.gitattributes(no longer needed)This is part 3/3 of the Cairo 1 on-demand compilation stack. After PR 2, these files are unused — this PR is pure cleanup.
Test plan
git grepconfirms no remaining references to the deleted file pathsMade with Cursor
Note
Low Risk
Low risk cleanup: removes generated Cairo 1 JSON artifacts and updates ignore/diff settings; runtime behavior should be unchanged as artifacts are now generated on-demand.
Overview
Removes previously committed Cairo 1 generated artifacts (
.casm.jsonand.sierra.json) fromblockifier_test_utilsfeature contract resources, leaving only directory placeholders.Updates repo hygiene so these artifacts are no longer treated specially in diffs and cannot be re-committed: drops the Cairo 1
-diffrules from.gitattributesand adds.gitignoreentries for the Cairo 1compiled/andsierra/JSON outputs.Written by Cursor Bugbot for commit de063fc. This will update automatically on new commits. Configure here.