refactor(starknet_http_server): use new metric fns#3576
Merged
Itay-Tsabary-Starkware merged 7 commits intomainfrom Jan 22, 2025
Merged
refactor(starknet_http_server): use new metric fns#3576Itay-Tsabary-Starkware merged 7 commits intomainfrom
Itay-Tsabary-Starkware merged 7 commits intomainfrom
Conversation
commit-id:9b02f0ff
…rate commit-id:a4047522
…nd gauge commit-id:304f3139
commit-id:b8fcb50f
… crate commit-id:c8fd2d12
commit-id:bc7ca07b
commit-id:c2ec900a
This was referenced Jan 21, 2025
yair-starkware
approved these changes
Jan 22, 2025
Contributor
yair-starkware
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_http_server/src/metrics.rs line 8 at r1 (raw file):
pub mod metrics_test; // Proposal metrics.
Remove?
Code quote:
// Proposal metrics.
Collaborator
Author
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
|
Artifacts upload workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit-id:c2ec900a
Stack: