Skip to content

refactor(starknet_http_server): use new metric fns#3576

Merged
Itay-Tsabary-Starkware merged 7 commits intomainfrom
spr/main/c2ec900a
Jan 22, 2025
Merged

refactor(starknet_http_server): use new metric fns#3576
Itay-Tsabary-Starkware merged 7 commits intomainfrom
spr/main/c2ec900a

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_http_server/src/metrics.rs line 8 at r1 (raw file):

pub mod metrics_test;

// Proposal metrics.

Remove?

Code quote:

// Proposal metrics.

Copy link
Collaborator Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/bc7ca07b to main January 22, 2025 09:31
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Jan 22, 2025
@github-actions
Copy link

Artifacts upload workflows:

Merged via the queue into main with commit b5adba0 Jan 22, 2025
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants