chore(blockifier): fn execute_txs_sequentially return state_diff + change privacy pub fn to fn

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): fn execute_txs return state_diff #3855
• chore(blockifier): rename execution_tast_output feild 'writes' to state_diff' #3871
• chore(blockifier): fn execute_txs_sequentially return state_diff + change privacy pub fn to fn  #3580 👈 (View in Graphite)
• main-v0.13.4

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-21T17:06:48Z
• Started at 2025-01-21T17:19:43Z
• Started at 2025-01-28T14:59:22Z
• Started at 2025-01-28T16:15:42Z
• Started at 2025-01-30T13:43:07Z
• Started at 2025-01-30T13:43:44Z
• Started at 2025-01-30T15:14:53Z
• Started at 2025-01-30T15:17:45Z
• Started at 2025-01-30T15:44:16Z
• Started at 2025-01-30T15:48:52Z
• Started at 2025-01-30T15:53:26Z
• Started at 2025-01-30T15:55:12Z
• Started at 2025-01-30T18:50:24Z
• Started at 2025-02-02T12:01:21Z
• Started at 2025-02-02T12:52:41Z

[noaov1]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 119 at r1 (raw file):

                let tx_state_changes_keys =
                    transactional_state.get_actual_state_changes()?.state_maps.into_keys();
                let state_diff = transactional_state.to_state_diff()?.state_maps.into();

Which is not the final object, right?

Code quote:

                let state_diff = transactional_state.to_state_diff()?.state_maps.into();

[noaov1]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 139 at r1 (raw file):

        &mut self,
        txs: &[Transaction],
    ) -> Vec<TransactionExecutorResult<TransactionExecutionInfo>> {

Let's return the state maps also by this method (and the ones that call it)

Code quote:

Vec<TransactionExecutorResult<TransactionExecutionInfo>> {

[avivg-starkware]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @noaov1)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 139 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Let's return the state maps also by this method (and the ones that call it)

Done

[noaov1]

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 106 at r2 (raw file):

        &mut self,
        tx: &Transaction,
    ) -> TransactionExecutorResult<TransactionExecutionOutput> {

What is TransactionExecutionOutput?

Code quote:

TransactionExecutorResult<TransactionExecutionOutput> {

---

crates/blockifier/src/blockifier/transaction_executor.rs line 237 at r2 (raw file):

        &mut self,
        txs: &[Transaction],
    ) -> Vec<TransactionExecutorResult<TransactionExecutionInfo>> {

Let's return the state diffs from this method as well

Code quote:

    pub fn execute_txs_sequentially(
        &mut self,
        txs: &[Transaction],
    ) -> Vec<TransactionExecutorResult<TransactionExecutionInfo>> {

[noaov1]

Reviewed 1 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

[avivg-starkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 106 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What is TransactionExecutionOutput?

sorry it was missing. should appear now

Code snippet:

pub type TransactionExecutionOutput = (TransactionExecutionInfo, StateMaps);

---

crates/blockifier/src/blockifier/transaction_executor.rs line 237 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Let's return the state diffs from this method as well

Done.

[avivg-starkware]

crates/blockifier/src/blockifier/transaction_executor.rs line 207 at r4 (raw file):

                .into_iter()
                .map(|res| res.map(|(tx_execution_info, _state_diff)| tx_execution_info))
                .collect()

in the next PR fn execute_txs ret val changes to Vec<TransactionExecutorResult<TransactionExecutionOutput >> and this code is removed

[Yoni-Starkware]

Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @noaov1)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 121 at r4 (raw file):

                let tx_state_changes_keys =
                    transactional_state.get_actual_state_changes()?.state_maps.into_keys();
                let state_diff = transactional_state.to_state_diff()?.state_maps;

You're doing the same work twice: swap order and replace into_keys with keys

Code quote:

                let tx_state_changes_keys =
                    transactional_state.get_actual_state_changes()?.state_maps.into_keys();
                let state_diff = transactional_state.to_state_diff()?.state_maps;

[Yoni-Starkware]

Reviewed 2 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @noaov1)

[avivg-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 121 at r4 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

You're doing the same work twice: swap order and replace into_keys with keys

I created an appropriate fn keys() WDYT? I'm indecisive about whether this implementation is better than just using into_keys()

[noaov1]

Reviewed 1 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

[avivg-starkware]

Reviewed 1 of 3 files at r1, 2 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)