refactor(blockifier): storage access tracker#3582
Conversation
|
This change is |
|
Artifacts upload workflows: |
aner-starkware
force-pushed
the
aner/storage_access_tracker
branch
3 times, most recently
from
b572293 to
63de7a7
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @Yoni-Starkware)
a discussion (no related file):
need a py side PR here, this is a breaking change
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
need a py side PR here, this is a breaking change
Why are we doing this? nice to have? we might end up moving the sets out of this class
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @Yoni-Starkware)
a discussion (no related file):
Previously, Yoni-Starkware (Yoni) wrote…
Why are we doing this? nice to have? we might end up moving the sets out of this class
nice to have. makes implementing any later decision easier
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
nice to have. makes implementing any later decision easier
Cool
aner-starkware
force-pushed
the
aner/storage_access_tracker
branch
from
63de7a7 to
c3adb90
Compare
Previously, Yoni-Starkware (Yoni) wrote…
Python side: |
aner-starkware
force-pushed
the
aner/storage_access_tracker
branch
2 times, most recently
from
b1cc191 to
7925e34
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware)
crates/starknet_consensus_orchestrator/resources/central_transaction_execution_info.json line 0 at r3 (raw file):
what's this diff...?
aner-starkware
force-pushed
the
aner/storage_access_tracker
branch
from
7925e34 to
1a448e1
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware)
aner-starkware
force-pushed
the
aner/storage_access_tracker
branch
from
1a448e1 to
bc2bbac
Compare
|
Previously, dorimedini-starkware wrote…
nesting |
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status:
commit-id:119376ef
4 participants
No description provided.