blockifier: remove fee builtins duplicacy in get_tx_weights #7521
Conversation
|
This change is |
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
3 times, most recently
from
76d15c1 to
f1c21f8
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
f1c21f8 to
7c8e93b
Compare
avivg-starkware
force-pushed
the
graphite-base/7521
branch
from
656da0b to
736e0f3
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
7c8e93b to
454a3e2
Compare
avivg-starkware
changed the title
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
4 times, most recently
from
905e2b5 to
d3bcb3e
Compare
avivg-starkware
requested review from
Yoni-Starkware,
meship-starkware and
noaov1
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
d3bcb3e to
2a6232f
Compare
avivg-starkware
changed the title
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)
crates/blockifier/src/execution/call_info.rs line 168 at r2 (raw file):
} pub fn remove_fee_builtins(&mut self, fee_info: &CallInfo) {
f2f
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
2a6232f to
fb0eb1e
Compare
avivg-starkware
force-pushed
the
graphite-base/7521
branch
from
9af50c1 to
6fc1e5a
Compare
avivg-starkware
changed the base branch from
graphite-base/7521
to
avivg/blockifier/split_execution_summary_to_builtins_sum
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
2 times, most recently
from
b9755d5 to
bf1b642
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/split_execution_summary_to_builtins_sum
branch
from
6fc1e5a to
2d00ab0
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
bf1b642 to
d30be77
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/split_execution_summary_to_builtins_sum
branch
from
2d00ab0 to
89ed6d8
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
2 times, most recently
from
725122a to
b29dad2
Compare
avivg-starkware
left a comment
avivg-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @meship-starkware, @noaov1, and @Yoni-Starkware)
crates/blockifier/src/execution/call_info.rs line 168 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
f2f
Done.
avivg-starkware
force-pushed
the
avivg/blockifier/split_execution_summary_to_builtins_sum
branch
from
89ed6d8 to
703f66a
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
b29dad2 to
1df300a
Compare
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r5, all commit messages.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @meship-starkware and @noaov1)
crates/blockifier/src/transaction/objects.rs line 217 at r4 (raw file):
/// Returns call infos excluding fee transfer (to avoid double-counting in bouncer calculations) pub fn call_infos_without_fee_transfer(&self) -> impl Iterator<Item = &CallInfo> {
Suggestion:
/// Returns call infos excluding fee transfer (to avoid double-counting in bouncer calculations).
pub fn non_optional_call_infos_without_fee_transfer(&self) -> impl Iterator<Item = &CallInfo> {
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r5.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware, @meship-starkware, and @noaov1)
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
1df300a to
58bf09f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/split_execution_summary_to_builtins_sum
branch
from
703f66a to
0ecd71e
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
58bf09f to
7863e52
Compare
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: 3 of 6 files reviewed, all discussions resolved (waiting on @meship-starkware and @noaov1)
avivg-starkware
changed the base branch from
avivg/blockifier/split_execution_summary_to_builtins_sum
to
graphite-base/7521
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
7863e52 to
78f052a
Compare
avivg-starkware
force-pushed
the
graphite-base/7521
branch
from
0ecd71e to
5bd55b1
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/add_fn_summarize_no_fee_builtins
branch
from
78f052a to
775593d
Compare
avivg-starkware
left a comment
avivg-starkware
left a comment
There was a problem hiding this comment.
merged #7766 becausenative-blockifier-artifacts-push keeps failing
Reviewable status: 2 of 6 files reviewed, all discussions resolved (waiting on @meship-starkware, @noaov1, and @Yoni-Starkware)
No description provided.