Skip to content

blockifier: box ExecutionError in TransactionExecutionError #7637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorimedini-starkware merged 1 commit into from
Jun 30, 2025
Merged

blockifier: box ExecutionError in TransactionExecutionError #7637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/apollo_rpc_execution/src/execution_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ fn blockifier_error_mapping() {
let child = blockifier::execution::errors::EntryPointExecutionError::RecursionDepthExceeded;
let selector = EntryPointSelector(felt!("0x111"));
let blockifier_err = BlockifierTransactionExecutionError::ExecutionError {
error: child,
error: Box::new(child),
class_hash,
storage_address,
selector,
Expand Down
2 changes: 1 addition & 1 deletion crates/blockifier/src/transaction/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ pub enum TransactionExecutionError {
DeclareTransactionError { class_hash: ClassHash },
#[error("{}", gen_tx_execution_error_trace(self))]
ExecutionError {
error: EntryPointExecutionError,
error: Box<EntryPointExecutionError>,
class_hash: ClassHash,
storage_address: ContractAddress,
selector: EntryPointSelector,
Expand Down
4 changes: 2 additions & 2 deletions crates/blockifier/src/transaction/transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ impl<S: State> Executable<S> for L1HandlerTransaction {

execute_call.non_reverting_execute(state, context, remaining_gas).map(Some).map_err(
|error| TransactionExecutionError::ExecutionError {
error,
error: Box::new(error),
class_hash,
storage_address,
selector,
Expand Down Expand Up @@ -312,7 +312,7 @@ impl<S: State> Executable<S> for InvokeTransaction {
let call_info =
execute_call.non_reverting_execute(state, context, remaining_gas).map_err(|error| {
TransactionExecutionError::ExecutionError {
error,
error: Box::new(error),
class_hash,
storage_address,
selector: entry_point_selector,
Expand Down
Loading