Skip to content

starknet_os: remove program input for python tests #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nimrod-starkware merged 1 commit into from
Jul 1, 2025
Merged

starknet_os: remove program input for python tests #7672

nimrod-starkware merged 1 commit into from
Jul 1, 2025
+42 −38

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jul 1, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jul 1, 2025

This change is Reviewable

@nimrod-starkware Graphite App
Copy link
Contributor Author

nimrod-starkware commented Jul 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware self-assigned this Jul 1, 2025
@nimrod-starkware nimrod-starkware force-pushed the nimrod/python_tests/remove_program_input branch from 818d282 to 9edf3b1 Compare July 1, 2025 05:47
@nimrod-starkware nimrod-starkware marked this pull request as ready for review July 1, 2025 05:47
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

Benchmark movements: No major performance changes detected.

nimrod-starkware
nimrod-starkware commented Jul 1, 2025
View reviewed changes
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python tests test_aliases, test_bls_field pass locally by simply ignoring the program
I'll open a PR on top of this one to move the tests to be rust tests and delete them from python.

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @amosStarkware and @dorimedini-starkware)

This was referenced Jul 1, 2025
Merged
Merged
dorimedini-starkware
dorimedini-starkware approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

crates/starknet_committer_and_os_cli/src/os_cli/tests/bls_field.rs line 0 at r1 (raw file):
are the dead_code annotations in this module still required?

@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main-v0.14.0 with commit 71419e3 Jul 1, 2025
15 checks passed
@nimrod-starkware nimrod-starkware mentioned this pull request Jul 1, 2025
Merged
victorkstarkware pushed a commit that referenced this pull request Jul 3, 2025
@nimrod-starkware @victorkstarkware
starknet_os: remove program input for python tests (#7672)
5d24d07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@amosStarkware amosStarkware Awaiting requested review from amosStarkware

Assignees

@nimrod-starkware nimrod-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nimrod-starkware @reviewable-StarkWare @dorimedini-starkware