blockifier: add l3 field to ChainInfo #7729
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
einat-starkware
force-pushed
the
einat/chain_info_l3_compatibility
branch
from
9ce0f2f to
5d86548
Compare
einat-starkware
force-pushed
the
einat/chain_info_l3_compatibility
branch
from
5d86548 to
56b7167
Compare
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions
config/sequencer/default_config.json line 126 at r1 (raw file):
"privacy": "Public", "value": false },
This should not be a config. The value should always be false.
Code quote:
"batcher_config.block_builder_config.chain_info.is_layer_3": {
"description": "Whether the chain is a layer 3 chain.",
"privacy": "Public",
"value": false
},crates/blockifier/src/context.rs line 203 at r1 (raw file):
pub chain_id: ChainId, pub fee_token_addresses: FeeTokenAddresses, pub is_layer_3: bool,
Suggestion:
pub is_L3: bool,
einat-starkware
force-pushed
the
einat/chain_info_l3_compatibility
branch
2 times, most recently
from
cdacf97 to
2c4e54d
Compare
einat-starkware
left a comment
einat-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)
config/sequencer/default_config.json line 126 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
This should not be a config. The value should always be
false.
Done.
crates/blockifier/src/context.rs line 203 at r1 (raw file):
pub chain_id: ChainId, pub fee_token_addresses: FeeTokenAddresses, pub is_layer_3: bool,
changed to is_l3 to be consistent with snake case formatting
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @einat-starkware)
einat-starkware
force-pushed
the
einat/chain_info_l3_compatibility
branch
from
2c4e54d to
9d4edbf
Compare
einat-starkware
left a comment
einat-starkware
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 3 of 7 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
einat-starkware
left a comment
einat-starkware
left a comment
There was a problem hiding this comment.
Reviewed 3 of 7 files at r2, 4 of 4 files at r3.
Reviewable status:
No description provided.