starknet_os: refactor cairo runner utils

[nimrod-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

• starknet_os: allocate and replace aliases test #7745 : 2 dependent PRs (#7765 , #7792 )
• starknet_os: refactor cairo runner utils #7744 👈 (View in Graphite)
• starknet_os: pointer args wrap Vec<MaybeRelocatable> #7743
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[amosStarkware]

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)

---

crates/starknet_os/src/test_utils/cairo_runner.rs line 571 at r2 (raw file):

    state_reader: Option<DictStateReader>,
) -> Cairo0EntryPointRunnerResult<(Vec<EndpointArg>, Vec<EndpointArg>, CairoRunner)> {
    let (mut cairo_runner, program, entrypoint) = initialize_cairo_runner(

Suggestion:

/// This function is split into to sub-functions to allow advanced use cases,
/// which require access to the cairo runner before running the entrypoint.
let (mut cairo_runner, program, entrypoint) = initialize_cairo_runner(

---

crates/starknet_os/src/test_utils/cairo_runner.rs line 595 at r2 (raw file):

    program_bytes: &[u8],
    entrypoint: &str,
    implicit_args: &[ImplicitArg],

Suggestion:

implicit_args: &[ImplicitArg], // Used to infer the builtins the program uses.

[nimrod-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware)

---

crates/starknet_os/src/test_utils/cairo_runner.rs line 571 at r2 (raw file):

    state_reader: Option<DictStateReader>,
) -> Cairo0EntryPointRunnerResult<(Vec<EndpointArg>, Vec<EndpointArg>, CairoRunner)> {
    let (mut cairo_runner, program, entrypoint) = initialize_cairo_runner(

Done.
you mean add as a comment, right? (with two slashes)

---

crates/starknet_os/src/test_utils/cairo_runner.rs line 595 at r2 (raw file):

    program_bytes: &[u8],
    entrypoint: &str,
    implicit_args: &[ImplicitArg],

Done.

[amosStarkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

---

crates/starknet_os/src/test_utils/cairo_runner.rs line 571 at r2 (raw file):

Previously, nimrod-starkware wrote…

Done.
you mean add as a comment, right? (with two slashes)

Yes, thanks.
non blocking - please change to -> two, my bad

[nimrod-starkware]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)