Skip to content

Merge constaking into main #7805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dafnamatsry merged 9 commits into from
Jul 8, 2025
Merged

Merge constaking into main #7805

dafnamatsry merged 9 commits into from
Jul 8, 2025

Conversation

@dafnamatsry
Copy link
Collaborator

@dafnamatsry dafnamatsry commented Jul 7, 2025

No description provided.

@dafnamatsry
Copy link
Collaborator Author

dafnamatsry commented Jul 7, 2025

Src Dst Cargo.lock
Src Dst crates/apollo_consensus_orchestrator/Cargo.toml
Src Dst crates/blockifier_test_utils/src/contracts.rs

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jul 7, 2025

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

Artifacts upload workflows:

@github-actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

Benchmark movements: No major performance changes detected.

@dafnamatsry dafnamatsry force-pushed the dafna/merge-constaking-into-main-1751870734 branch 2 times, most recently from b044e92 to 11c4526 Compare July 7, 2025 08:15
matanl-starkware
matanl-starkware approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 6 files at r1, 3 of 4 files at r2, 1 of 4 files at r3, 2 of 2 files at r4, 2 of 3 files at r8, 4 of 7 files at r9, 4 of 4 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@dafnamatsry dafnamatsry force-pushed the dafna/merge-constaking-into-main-1751870734 branch 2 times, most recently from ad9cdf1 to ce0d3f1 Compare July 8, 2025 09:37
@dafnamatsry dafnamatsry force-pushed the dafna/merge-constaking-into-main-1751870734 branch from ce0d3f1 to 051bb97 Compare July 8, 2025 10:43
matanl-starkware
matanl-starkware approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 15 files at r13, 2 of 2 files at r17, 1 of 4 files at r19, all commit messages.
Reviewable status: 6 of 17 files reviewed, all discussions resolved (waiting on @dafnamatsry)

dafnamatsry
dafnamatsry commented Jul 8, 2025
View reviewed changes
Copy link
Collaborator Author

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r15, 2 of 4 files at r16, 1 of 4 files at r19, 1 of 3 files at r20, 2 of 3 files at r21, 3 of 3 files at r22.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@dafnamatsry dafnamatsry added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit 0131283 Jul 8, 2025
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matanl-starkware matanl-starkware matanl-starkware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dafnamatsry @reviewable-StarkWare @matanl-starkware