Skip to content

Conversation

@ishay-starkware
Copy link
Collaborator

@ishay-starkware ishay-starkware commented Oct 29, 2025

Note

Introduces a dedicated Fulfillment component and refactors Core and Vault flows to use it for order/request fulfillment instead of inline maps and errors.

  • Core:
    • Fulfillment integration: Registers new FulfillmentComponent (storage, events) and replaces inline fulfillment map/method with fulfillment.update_fulfillment in trade and liquidate flows.
    • Cleanup: Removes core-level fulfillment storage and fulfillment_exceeded_err from errors.cairo; minor import tidy-ups.
  • Vault:
    • Fulfillment integration: Adds FulfillmentComponent dependency; uses update_fulfillment during deposit_into_vault and redeem_from_vault validations.
    • Cleanup: Removes fulfilled_vault_requests tracking and the VAULT_REQUEST_ALREADY_FULFILLED error; streamlines storage/imports.
  • Components:
    • New module: components/fulfillment with FulfillmentComponent (stores per-order fulfillment and enforces overfill via FULFILLMENT_EXCEEDED).

Written by Cursor Bugbot for commit a182870. This will update automatically on new commits. Configure here.


This change is Reviewable

cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the ishay/fulfillment-comp branch 2 times, most recently from e8286c3 to d591327 Compare November 2, 2025 12:56
@github-actions github-actions bot force-pushed the ishay/fulfillment-comp branch from d591327 to a182870 Compare November 5, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants