chore(perpetuals): add token address to deposit events #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammadNassar1
force-pushed
the
mohammad/deposit-event/add-token-address
branch
from
3cb6cf5 to
59fbdce
Compare
github-actions
bot
force-pushed
the
mohammad/deposit-event/add-token-address
branch
from
59fbdce to
fa2b2cf
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
workspace/apps/perpetuals/contracts/src/core/components/deposit/events.cairo
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
mohammad/deposit-event/add-token-address
branch
from
fa2b2cf to
1a3a137
Compare
MohammadNassar1
force-pushed
the
mohammad/deposit-event/add-token-address
branch
from
1a3a137 to
367a86e
Compare
MohammadNassar1
commented
Dec 29, 2025
Collaborator
Author
MohammadNassar1
left a comment
MohammadNassar1
left a comment
There was a problem hiding this comment.
@MohammadNassar1 resolved 1 discussion.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @MohammadNassar1).
github-actions
bot
force-pushed
the
mohammad/deposit-event/add-token-address
branch
4 times, most recently
from
56d0c5b to
2ccd3a4
Compare
github-actions
bot
force-pushed
the
mohammad/deposit-event/add-token-address
branch
from
2ccd3a4 to
c35af2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds token contract address context to all deposit-related events and aligns emitters and tests.
events.cairostructsDeposit,DepositProcessed,DepositCanceledwithtoken_addressdeposit_manager.cairoto populatetoken_addresswhen emittingDeposit,DepositCanceled,DepositProcessedevent_test_utils.cairo) and flow/unit tests to assert the newtoken_addressfieldWritten by Cursor Bugbot for commit c35af2a. This will update automatically on new commits. Configure here.
This change is