chore(perpetuals): add token address to deposit and withdraw events#176
Merged
MohammadNassar1 merged 1 commit intodevfrom Jan 14, 2026
Merged
Conversation
3cb6cf5 to
59fbdce
Compare
59fbdce to
fa2b2cf
Compare
workspace/apps/perpetuals/contracts/src/core/components/deposit/events.cairo
Show resolved
Hide resolved
fa2b2cf to
1a3a137
Compare
1a3a137 to
367a86e
Compare
MohammadNassar1
commented
Dec 29, 2025
Collaborator
Author
MohammadNassar1
left a comment
There was a problem hiding this comment.
@MohammadNassar1 resolved 1 discussion.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @MohammadNassar1).
56d0c5b to
2ccd3a4
Compare
2ccd3a4 to
c35af2a
Compare
c35af2a to
20f4afa
Compare
RoeeGross
approved these changes
Jan 14, 2026
Collaborator
RoeeGross
left a comment
There was a problem hiding this comment.
@RoeeGross reviewed 7 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ishay-starkware).
RoeeGross
approved these changes
Jan 14, 2026
Collaborator
RoeeGross
left a comment
There was a problem hiding this comment.
@RoeeGross made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ishay-starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduces
token_addressin key events to make the emitting token explicit.Deposit,DepositProcessed,DepositCanceled,Withdraw, andForcedWithdrawevents withtoken_address(indeposit/events.cairo,withdrawal_manager.cairo, andcore/events.cairo)deposit_manager.cairoandwithdrawal_manager.cairo;_withdrawnow returns(hash, token_address)for event emissiontoken_addressacross deposit/withdraw flows (event_test_utils.cairo, flow and unit tests)Written by Cursor Bugbot for commit 20f4afa. This will update automatically on new commits. Configure here.
This change is