Skip to content

Comments

chore(perpetuals): add token address to deposit and withdraw events#176

Merged
MohammadNassar1 merged 1 commit intodevfrom
mohammad/deposit-event/add-token-address
Jan 14, 2026
Merged

chore(perpetuals): add token address to deposit and withdraw events#176
MohammadNassar1 merged 1 commit intodevfrom
mohammad/deposit-event/add-token-address

Conversation

@MohammadNassar1
Copy link
Collaborator

@MohammadNassar1 MohammadNassar1 commented Dec 28, 2025

Note

Introduces token_address in key events to make the emitting token explicit.

  • Extend Deposit, DepositProcessed, DepositCanceled, Withdraw, and ForcedWithdraw events with token_address (in deposit/events.cairo, withdrawal_manager.cairo, and core/events.cairo)
  • Update emit sites in deposit_manager.cairo and withdrawal_manager.cairo; _withdraw now returns (hash, token_address) for event emission
  • Adjust tests and helpers to assert token_address across deposit/withdraw flows (event_test_utils.cairo, flow and unit tests)

Written by Cursor Bugbot for commit 20f4afa. This will update automatically on new commits. Configure here.


This change is Reviewable

@MohammadNassar1 MohammadNassar1 self-assigned this Dec 28, 2025
@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/deposit-event/add-token-address branch from 3cb6cf5 to 59fbdce Compare December 28, 2025 13:57
@github-actions github-actions bot force-pushed the mohammad/deposit-event/add-token-address branch from 59fbdce to fa2b2cf Compare December 28, 2025 14:04
@github-actions github-actions bot force-pushed the mohammad/deposit-event/add-token-address branch from fa2b2cf to 1a3a137 Compare December 28, 2025 14:43
@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/deposit-event/add-token-address branch from 1a3a137 to 367a86e Compare December 29, 2025 09:19
Copy link
Collaborator Author

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohammadNassar1 resolved 1 discussion.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @MohammadNassar1).

@github-actions github-actions bot force-pushed the mohammad/deposit-event/add-token-address branch 4 times, most recently from 56d0c5b to 2ccd3a4 Compare January 1, 2026 14:48
@github-actions github-actions bot force-pushed the mohammad/deposit-event/add-token-address branch from 2ccd3a4 to c35af2a Compare January 6, 2026 11:19
@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/deposit-event/add-token-address branch from c35af2a to 20f4afa Compare January 14, 2026 08:25
Copy link
Collaborator

@RoeeGross RoeeGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoeeGross reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ishay-starkware).

Copy link
Collaborator

@RoeeGross RoeeGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@RoeeGross made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ishay-starkware).

@MohammadNassar1 MohammadNassar1 enabled auto-merge (squash) January 14, 2026 08:29
@MohammadNassar1 MohammadNassar1 changed the title chore(perpetuals): add token address to deposit events chore(perpetuals): add token address to deposit and withdraw events Jan 14, 2026
@MohammadNassar1 MohammadNassar1 merged commit 1b901da into dev Jan 14, 2026
4 checks passed
@MohammadNassar1 MohammadNassar1 deleted the mohammad/deposit-event/add-token-address branch January 14, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants