feat: opt risk factor

[RoeeGross]

Note

Packs risk config into optimized storage and migrates data, updates risk-factor lookup, refactors trade order validation reuse, and adjusts tests/interface.

• Assets:
  • Introduce packed RiskConfig with StorePacking and new storage: risk_config and risk_factor_tiers_opt.
  • Add migrate_risk() to populate new structures from existing asset_config and risk_factor_tiers.
  • Update get_asset_risk_factor to use risk_config and risk_factor_tiers_opt.read.
• Core:
  • Refactor _validate_order to accept optional now/collateral_id and return them; reuse in _validate_trade.
  • Remove active-asset validation in _validate_trade (commented out).
• Types:
  • Add RiskConfig struct and StorePacking<RiskConfig, felt252> implementation.
• Interface/Tests:
  • Expose migrate_risk in IAssets and call it in performance test before multi_trade.

^{Written by Cursor Bugbot for commit fecd82d. This will update automatically on new commits. Configure here.}

---

This change is 

[cursor]

Bug: Timestamp Overwrite Causes Inconsistent Validation

The _validate_order function recomputes the now timestamp on line 1306, overwriting the value initially set from the optional parameter. This defeats the optimization to reuse a consistent timestamp across multiple order validations, leading to redundant Time::now() calls and potentially inconsistent expiration checks.

workspace/apps/perpetuals/contracts/src/core/core.cairo#L1305-L1306

starknet-perpetual/workspace/apps/perpetuals/contracts/src/core/core.cairo

Lines 1305 to 1306 in e0bd885

	// Expiration check.
	let now = Time::now();

 

---

[cursor]

Bug: Redundant Time::now() Call Breaks Timestamp Consistency

Duplicate Time::now() call in _validate_order function. The now variable is already computed at lines 1108-1112, but line 1127 calls Time::now() again, overwriting the parameter value. This defeats the purpose of passing now as an optional parameter for reuse between order_a and order_b validation, potentially causing inconsistent timestamp checks.

 

[cursor]

Bug: New Assets Lack Risk Config Initialization

get_asset_risk_factor reads from risk_config and risk_factor_tiers_opt storage fields, but the _add_asset function (which adds new assets) does not populate these fields. Only the migrate_risk function populates them. This means newly added assets will have default/zero values for risk configuration, causing incorrect risk factor calculations until migrate_risk is manually called. The _add_asset function should populate these new storage fields when adding an asset.

 

[remollemo]

Reviewable status: 0 of 7 files reviewed, 8 unresolved discussions (waiting on @RoeeGross)

---

workspace/apps/perpetuals/contracts/src/core/types/asset.cairo line 117 at r9 (raw file):

}

/// ┌──────────────────────────────────────────────────────────────┐

almost good
make really good

---

workspace/apps/perpetuals/contracts/src/core/components/assets/assets.cairo line 179 at r9 (raw file):

                    let value = vec.at(i.into()).read();
                    self.risk_factor_tiers_opt.entry(asset_id).write(i.into(), value);
                }

rethink, redo

1. not in the same place
2. consider alternative to map

Code quote:

                let vec = self.risk_factor_tiers.entry(asset_id);
                for i in 0..vec.len() {
                    let value = vec.at(i.into()).read();
                    self.risk_factor_tiers_opt.entry(asset_id).write(i.into(), value);
                }