Skip to content

ci: add PR CI#24

Merged
arad-starkware merged 1 commit intomainfrom
arad/ci_add_pr_ci
Nov 17, 2025
Merged

ci: add PR CI#24
arad-starkware merged 1 commit intomainfrom
arad/ci_add_pr_ci

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Nov 17, 2025

Note

Adds a PR GitHub Actions workflow running flow verification, tests with coverage upload, and formatting checks; adjusts flow-check script path and enables dev Cairo debug profile.

  • CI (GitHub Actions):
    • Adds on-pull-request.yaml with jobs:
      • verify_flows: sets up Python and runs scripts/check_all_flows_have_test.py --allow-duplicate-tests.
      • test: sets up Starknet Foundry 0.49.0, Scarb 2.12.2, installs cairo-coverage, runs scarb test -w --coverage, uploads coverage.lcov to Codecov, and checks formatting via scarb fmt -w --check.
  • Scripts:
    • Updates scripts/check_all_flows_have_test.py to fix CONTRACTS_FOLDER path resolution.
  • Contracts config:
    • Updates workspace/apps/staking/contracts/Scarb.toml with [profile.dev.cairo] enabling debug info and setting inlining-strategy = "avoid".

Written by Cursor Bugbot for commit 45cee2c. This will update automatically on new commits. Configure here.


This change is Reviewable

@arad-starkware arad-starkware self-assigned this Nov 17, 2025
@arad-starkware arad-starkware force-pushed the arad/ci_add_pr_ci branch 3 times, most recently from e7383f0 to dbc491c Compare November 17, 2025 11:38
@codecov
Copy link

codecov bot commented Nov 17, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@arad-starkware arad-starkware force-pushed the arad/ci_add_pr_ci branch 3 times, most recently from 00e2f3f to c4aaec4 Compare November 17, 2025 12:18
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @NirLevi-starkware)

@arad-starkware arad-starkware merged commit 487c79e into main Nov 17, 2025
6 of 7 checks passed
@arad-starkware arad-starkware deleted the arad/ci_add_pr_ci branch November 17, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants