Skip to content

test: find sigma tests should be multi version #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noa-starkware merged 3 commits into from
Nov 20, 2025
Merged

test: find sigma tests should be multi version #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffcbb91
test: find sigma tests should be multi version
noa-starkware Nov 20, 2025
65dfb50
Merge branch 'main' into noa/staking/v3/test/find-sigma-multi
noa-starkware Nov 20, 2025
ed4305b
Merge branch 'main' into noa/staking/v3/test/find-sigma-multi
noa-starkware Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions workspace/apps/staking/contracts/src/flow_test/flows.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6421,8 +6421,12 @@ pub(crate) struct FindSigmaMigrationFlow {
pub(crate) delegator: Option<Delegator>,
pub(crate) member_rewards: Option<Amount>,
}
pub(crate) impl FindSigmaMigrationFlowImpl of FlowTrait<FindSigmaMigrationFlow> {
fn setup_v2(ref self: FindSigmaMigrationFlow, ref system: SystemState) {
pub(crate) impl FindSigmaMigrationFlowImpl of MultiVersionFlowTrait<FindSigmaMigrationFlow> {
fn versions(self: FindSigmaMigrationFlow) -> Span<ReleaseVersion> {
[V1, V2].span()
}

fn setup(ref self: FindSigmaMigrationFlow, ref system: SystemState) {
let amount = system.staking.get_min_stake();
let staker = system.new_staker(:amount);
let commission = 200;
Expand Down Expand Up @@ -6456,7 +6460,7 @@ pub(crate) impl FindSigmaMigrationFlowImpl of FlowTrait<FindSigmaMigrationFlow>
system.set_staker_for_migration(staker_address: staker.staker.address);
}

fn test(self: FindSigmaMigrationFlow, ref system: SystemState) {
fn test(self: FindSigmaMigrationFlow, ref system: SystemState, version: ReleaseVersion) {
let pool = self.pool.unwrap();
let expected_class_hash = declare_pool_contract();
assert!(get_class_hash(contract_address: pool) == expected_class_hash);
Expand All @@ -6479,8 +6483,14 @@ pub(crate) struct FindSigmaEdgeCasesMigrationFlow {
pub(crate) delegator: Option<Delegator>,
pub(crate) member_rewards: Option<Amount>,
}
pub(crate) impl FindSigmaEdgeCasesMigrationFlowImpl of FlowTrait<FindSigmaEdgeCasesMigrationFlow> {
fn setup_v2(ref self: FindSigmaEdgeCasesMigrationFlow, ref system: SystemState) {
pub(crate) impl FindSigmaEdgeCasesMigrationFlowImpl of MultiVersionFlowTrait<
FindSigmaEdgeCasesMigrationFlow,
> {
fn versions(self: FindSigmaEdgeCasesMigrationFlow) -> Span<ReleaseVersion> {
[V1, V2].span()
}

fn setup(ref self: FindSigmaEdgeCasesMigrationFlow, ref system: SystemState) {
let amount = system.staking.get_min_stake();
let staker = system.new_staker(:amount);
let commission = 200;
Expand All @@ -6506,7 +6516,9 @@ pub(crate) impl FindSigmaEdgeCasesMigrationFlowImpl of FlowTrait<FindSigmaEdgeCa
system.set_staker_for_migration(staker_address: staker.staker.address);
}

fn test(self: FindSigmaEdgeCasesMigrationFlow, ref system: SystemState) {
fn test(
self: FindSigmaEdgeCasesMigrationFlow, ref system: SystemState, version: ReleaseVersion,
) {
let pool = self.pool.unwrap();
let expected_class_hash = declare_pool_contract();
assert!(get_class_hash(contract_address: pool) == expected_class_hash);
Expand All @@ -6529,8 +6541,14 @@ pub(crate) struct FindSigmaMigrationIdxIsOneFlow {
pub(crate) delegator: Option<Delegator>,
pub(crate) member_rewards: Option<Amount>,
}
pub(crate) impl FindSigmaMigrationIdxIsOneFlowImpl of FlowTrait<FindSigmaMigrationIdxIsOneFlow> {
fn setup_v2(ref self: FindSigmaMigrationIdxIsOneFlow, ref system: SystemState) {
pub(crate) impl FindSigmaMigrationIdxIsOneFlowImpl of MultiVersionFlowTrait<
FindSigmaMigrationIdxIsOneFlow,
> {
fn versions(self: FindSigmaMigrationIdxIsOneFlow) -> Span<ReleaseVersion> {
[V1, V2].span()
}

fn setup(ref self: FindSigmaMigrationIdxIsOneFlow, ref system: SystemState) {
let amount = system.staking.get_min_stake();
let staker = system.new_staker(:amount);
let commission = 200;
Expand All @@ -6551,7 +6569,9 @@ pub(crate) impl FindSigmaMigrationIdxIsOneFlowImpl of FlowTrait<FindSigmaMigrati
system.set_staker_for_migration(staker_address: staker.staker.address);
}

fn test(self: FindSigmaMigrationIdxIsOneFlow, ref system: SystemState) {
fn test(
self: FindSigmaMigrationIdxIsOneFlow, ref system: SystemState, version: ReleaseVersion,
) {
let pool = self.pool.unwrap();
let expected_class_hash = declare_pool_contract();
assert!(get_class_hash(contract_address: pool) == expected_class_hash);
Expand Down
27 changes: 0 additions & 27 deletions workspace/apps/staking/contracts/src/flow_test/fork_test.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,33 +402,6 @@ fn staking_prev_class_hash_flow_test() {
test_flow_mainnet(ref :flow);
}

#[test]
#[fork("MAINNET_LATEST")]
fn find_sigma_migration_flow_test() {
let mut flow = flows::FindSigmaMigrationFlow {
pool: Option::None, delegator: Option::None, member_rewards: Option::None,
};
test_flow_mainnet(ref :flow);
}

#[test]
#[fork("MAINNET_LATEST")]
fn find_sigma_edge_cases_migration_flow_test() {
let mut flow = flows::FindSigmaEdgeCasesMigrationFlow {
pool: Option::None, delegator: Option::None, member_rewards: Option::None,
};
test_flow_mainnet(ref :flow);
}

#[test]
#[fork("MAINNET_LATEST")]
fn find_sigma_migration_idx_is_one_flow_test() {
let mut flow = flows::FindSigmaMigrationIdxIsOneFlow {
pool: Option::None, delegator: Option::None, member_rewards: Option::None,
};
test_flow_mainnet(ref :flow);
}

#[test]
#[fork("MAINNET_LATEST")]
fn staker_migration_skip_version_flow_test() {
Expand Down
27 changes: 27 additions & 0 deletions workspace/apps/staking/contracts/src/flow_test/multi_version_tests.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,3 +141,30 @@ fn intent_upgrade_set_public_key_flow_test() {
let mut flow = flows::IntentUpgradeSetPublicKeyFlow { staker: Option::None };
test_multi_version_flow_mainnet(ref :flow);
}

#[test]
#[fork("MAINNET_LATEST")]
fn find_sigma_migration_flow_test() {
let mut flow = flows::FindSigmaMigrationFlow {
pool: Option::None, delegator: Option::None, member_rewards: Option::None,
};
test_multi_version_flow_mainnet(ref :flow);
}

#[test]
#[fork("MAINNET_LATEST")]
fn find_sigma_edge_cases_migration_flow_test() {
let mut flow = flows::FindSigmaEdgeCasesMigrationFlow {
pool: Option::None, delegator: Option::None, member_rewards: Option::None,
};
test_multi_version_flow_mainnet(ref :flow);
}

#[test]
#[fork("MAINNET_LATEST")]
fn find_sigma_migration_idx_is_one_flow_test() {
let mut flow = flows::FindSigmaMigrationIdxIsOneFlow {
pool: Option::None, delegator: Option::None, member_rewards: Option::None,
};
test_multi_version_flow_mainnet(ref :flow);
}