Skip to content

test: find sigma tests should be multi version#36

Merged
noa-starkware merged 3 commits intomainfrom
noa/staking/v3/test/find-sigma-multi
Nov 20, 2025
Merged

test: find sigma tests should be multi version#36
noa-starkware merged 3 commits intomainfrom
noa/staking/v3/test/find-sigma-multi

Conversation

@noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Nov 20, 2025

Note

Converts FindSigma* migration flows to MultiVersionFlowTrait (V1,V2) and moves their tests from fork_test.cairo to multi_version_tests.cairo.

  • Tests (multi-version):
    • Convert flows to MultiVersionFlowTrait with versions() -> [V1, V2] and unified setup/test(..., version):
      • FindSigmaMigrationFlow
      • FindSigmaEdgeCasesMigrationFlow
      • FindSigmaMigrationIdxIsOneFlow
    • Move corresponding tests from flow_test/fork_test.cairo to flow_test/multi_version_tests.cairo (using test_multi_version_flow_mainnet).

Written by Cursor Bugbot for commit ed4305b. This will update automatically on new commits. Configure here.


This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.43%. Comparing base (d05bb77) to head (ed4305b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   95.94%   95.43%   -0.51%     
==========================================
  Files          47       45       -2     
  Lines       11703     9446    -2257     
==========================================
- Hits        11228     9015    -2213     
+ Misses        475      431      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

@noa-starkware noa-starkware merged commit a28d60e into main Nov 20, 2025
5 of 7 checks passed
@noa-starkware noa-starkware deleted the noa/staking/v3/test/find-sigma-multi branch November 20, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants