Skip to content

test: rename strk_pool_update_rewards_v0 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noa-starkware merged 2 commits into from
Nov 20, 2025
Merged

test: rename strk_pool_update_rewards_v0 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
249ca7a
test: rename strk_pool_update_rewards_v0
noa-starkware Nov 20, 2025
46fda21
Merge branch 'main' into noa/staking/v3/tests/strk_pool_update_reward…
noa-starkware Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workspace/apps/staking/contracts/src/flow_test/flows.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ use staking::test_utils::{
calculate_staker_strk_rewards_v2, calculate_strk_pool_rewards_v2,
calculate_strk_pool_rewards_with_pool_balance_v2, compute_rewards_per_unit,
declare_pool_contract, declare_pool_eic_contract, declare_staking_contract,
load_from_simple_map, load_one_felt, strk_pool_update_rewards_v1, to_amount_18_decimals,
load_from_simple_map, load_one_felt, strk_pool_update_rewards_v0, to_amount_18_decimals,
upgrade_implementation,
};
use staking::types::{Amount, Commission};
Expand Down Expand Up @@ -1278,7 +1278,7 @@ pub(crate) impl PoolMemberInfoAfterUpgradeFlowImpl of FlowTrait<PoolMemberInfoAf
.internal_pool_member_info(:delegator, :pool);
let get_internal_pool_member_info_after_upgrade = system
.get_internal_pool_member_info(:delegator, :pool);
let expected_pool_member_info = strk_pool_update_rewards_v1(
let expected_pool_member_info = strk_pool_update_rewards_v0(
pool_member_info: self.delegator_info.unwrap(),
updated_index: system.staking.get_global_index(),
);
Expand Down
4 changes: 2 additions & 2 deletions workspace/apps/staking/contracts/src/test_utils.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,10 +910,10 @@ pub(crate) fn advance_k_epochs_global() {
}
}

// ---- Calculate Rewards - V1 -----
// ---- Calculate Rewards - V0 (index based) -----

/// Update rewards for STRK pool.
pub(crate) fn strk_pool_update_rewards_v1(
pub(crate) fn strk_pool_update_rewards_v0(
pool_member_info: PoolMemberInfo, updated_index: Index,
) -> PoolMemberInfo {
let interest: Index = updated_index - pool_member_info.index;
Expand Down