Skip to content

test: rename strk_pool_update_rewards_v0#37

Merged
noa-starkware merged 2 commits intomainfrom
noa/staking/v3/tests/strk_pool_update_rewards_v0
Nov 20, 2025
Merged

test: rename strk_pool_update_rewards_v0#37
noa-starkware merged 2 commits intomainfrom
noa/staking/v3/tests/strk_pool_update_rewards_v0

Conversation

@noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Nov 20, 2025

This change is Reviewable


Note

Renames the STRK pool rewards update helper to strk_pool_update_rewards_v0 and updates imports/usages in flow tests.

  • Tests/Utils:
    • Rename strk_pool_update_rewards_v1 to strk_pool_update_rewards_v0 in workspace/apps/staking/contracts/src/test_utils.cairo and adjust comment header.
  • Flow Tests:
    • Update imports and usage in workspace/apps/staking/contracts/src/flow_test/flows.cairo to call strk_pool_update_rewards_v0 (e.g., in PoolMemberInfoAfterUpgradeFlow).

Written by Cursor Bugbot for commit 46fda21. This will update automatically on new commits. Configure here.

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.43%. Comparing base (d05bb77) to head (46fda21).
⚠️ Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   95.94%   95.43%   -0.51%     
==========================================
  Files          47       45       -2     
  Lines       11703     9446    -2257     
==========================================
- Hits        11228     9015    -2213     
+ Misses        475      431      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noa-starkware noa-starkware merged commit 060e19f into main Nov 20, 2025
6 of 7 checks passed
@noa-starkware noa-starkware deleted the noa/staking/v3/tests/strk_pool_update_rewards_v0 branch November 20, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants