Conversation
4e31646 to
9b801e3
Compare
9b801e3 to
0cbc327
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 42 42
Lines 9754 9754
=======================================
Hits 9325 9325
Misses 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NirLevi-starkware
left a comment
There was a problem hiding this comment.
@NirLevi-starkware reviewed 1 of 3 files at r1, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noa-starkware)
src/flow_test/flow_ideas.md line 56 at r4 (raw file):
- find sigma: Enter V0, change in V2, catch all ifs. - find sigma_edge_cases: catch the comments. - find sigma - cover all branches with member from V0, V1, V2(V2 DONE).
why did you delete this?
src/flow_test/flow_ideas.md line 58 at r4 (raw file):
- find sigma - cover all branches with member from V0, V1, V2(V2 DONE). - member from V0, update balance at V3 before getting rewards, pool gets rewards, test rewards. - member from V0, pool gets rewards at V1, update balance at V3 before getting rewards, pool gets rewards, test rewards.
i dont see flow of this one.
src/flow_test/flows.cairo line 7186 at r4 (raw file):
/// Attest in V1 (pool gets rewards). /// Attest in V2 (pool gets rewards). /// Attest in V3 (pool gets rewards).
i dont see 3 different attestations here. we sould have here setup_v2 no?
0cbc327 to
36e9a96
Compare
noa-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on @NirLevi-starkware)
src/flow_test/flow_ideas.md line 56 at r4 (raw file):
Previously, NirLevi-starkware (Nir Levi) wrote…
why did you delete this?
revert
src/flow_test/flow_ideas.md line 58 at r4 (raw file):
Previously, NirLevi-starkware (Nir Levi) wrote…
i dont see flow of this one.
Done.
src/flow_test/flows.cairo line 7186 at r4 (raw file):
Previously, NirLevi-starkware (Nir Levi) wrote…
i dont see 3 different attestations here. we sould have here setup_v2 no?
Done.
NirLevi-starkware
left a comment
There was a problem hiding this comment.
@NirLevi-starkware reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)
36e9a96 to
942f38d
Compare
NirLevi-starkware
left a comment
There was a problem hiding this comment.
@NirLevi-starkware reviewed 3 of 3 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)
Note
Adds four delegator cross-version reward/balance-change flows (V0→V3) and wires them into mainnet fork tests, introducing a v1 STRK pool rewards calc helper.
DelegatorChangeBalanceOverVersionsFlow,DelegatorFromV0Flow,DelegatorV0ChangeBalanceBeforeRewardsFlow, andDelegatorV0RewardsV1ChangeBalanceBeforeRewardsFlow:V0, attesting acrossV1/V2/V3, changing balances inV1/V3, and verifying rewards via view and claim.calculate_strk_pool_rewards_v1to compute expected rewards forV1epochs.Written by Cursor Bugbot for commit 942f38d. This will update automatically on new commits. Configure here.
This change is