test: add update_rewards strk pool flow

[arad-starkware]

This change is 

---

Note

Adds a flow test for update_rewards with a STRK pool under consensus rewards and a start_consensus_rewards helper; updates flow ideas.

• Tests:
  • Add update_rewards_strk_pool_flow_test in src/flow_test/test.cairo to validate staker rewards post-update_rewards and delegator rewards after next epoch under consensus STRK pool.
• Utilities:
  • Add SystemState.start_consensus_rewards() in src/flow_test/utils.cairo to set consensus_rewards_first_epoch and advance K epochs.
• Docs:
  • Update src/flow_test/flow_ideas.md by removing STRK-only pool case from update_rewards ideas.

^{Written by Cursor Bugbot for commit 5b22f3d. This will update automatically on new commits. Configure here.}

[arad-starkware]

• test: add update_rewards strk pool flow #46 👈 (View in Graphite)
• test: add disable_rewards flow #49 : 1 other dependent PR (#50 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (a28d60e) to head (5b22f3d).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   95.43%   95.61%   +0.17%     
==========================================
  Files          45       45              
  Lines        9446     9806     +360     
==========================================
+ Hits         9015     9376     +361     
+ Misses        431      430       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[noa-starkware]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/utils.cairo line 1525 at r2 (raw file):

        self.set_consensus_rewards_first_epoch(:epoch_id);
        self.advance_k_epochs();
    }

different trait?

Code quote:

    fn start_consensus_rewards(self: SystemState) {
        let epoch_id = self.staking.get_current_epoch() + K.into();
        self.set_consensus_rewards_first_epoch(:epoch_id);
        self.advance_k_epochs();
    }

---

src/flow_test/test.cairo line 2762 at r2 (raw file):

/// Flow:
/// Start consensus rewards.
/// Staker stake with STRK pool.

Is it the same behavior with empty BTC pool? Do we want to test that?

---

src/flow_test/test.cairo line 2767 at r2 (raw file):

/// update_rewards.
/// Test staker rewards.
/// Test delegator rewards.

Unnecessary IMO

Code quote:

Test delegator rewards.

---

src/flow_test/test.cairo line 2795 at r2 (raw file):

    );
    let staker_rewards = system.staker_claim_rewards(:staker);
    let delegator_rewards = system.delegator_claim_rewards(:delegator, :pool);

Unnecessary

[arad-starkware]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @noa-starkware)

---

src/flow_test/test.cairo line 2762 at r2 (raw file):

Previously, noa-starkware wrote…

Is it the same behavior with empty BTC pool? Do we want to test that?

There's a different flow for that, or I didn't understand

---

src/flow_test/test.cairo line 2767 at r2 (raw file):

Previously, noa-starkware wrote…

Unnecessary IMO

Why not test the expected behavior? Is this tested somewhere else?

---

src/flow_test/utils.cairo line 1525 at r2 (raw file):

Previously, noa-starkware wrote…

different trait?

Done.

[noa-starkware]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/test.cairo line 2767 at r2 (raw file):

Previously, arad-starkware wrote…

Why not test the expected behavior? Is this tested somewhere else?

It is not related to this test. And it should be tested somewhere. But i dont care to leave it

---

src/flow_test/utils.cairo line 578 at r4 (raw file):

    }

    fn start_consensus_rewards(self: SystemState) {

I think it should be in the same trait of advance epoch

[arad-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @noa-starkware)

---

src/flow_test/test.cairo line 2767 at r2 (raw file):

Previously, noa-starkware wrote…

It is not related to this test. And it should be tested somewhere. But i dont care to leave it

I'd rather leave it then

---

src/flow_test/utils.cairo line 578 at r4 (raw file):

Previously, noa-starkware wrote…

I think it should be in the same trait of advance epoch

Done.

[noa-starkware]

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @arad-starkware)

[arad-starkware]

Merge activity

• Nov 24, 8:04 AM UTC: Graphite rebased this pull request as part of a merge.
• Nov 24, 8:07 AM UTC: @arad-starkware merged this pull request with Graphite.