test: add token state after upgrade flow

[arad-starkware]

This change is 

---

Note

Adds a new regression flow to validate enabling/disabling BTC tokens across upgrade and consensus phases, wires it into fork tests, and imports v3 BTC pool rewards calc; minor doc cleanup.

• Flow tests:
  • Add EnableDisableTokenBeforeAfterUpgradeFlow in src/flow_test/flows.cairo:
    • Sets up two BTC tokens, delegates, toggles enable/disable across an upgrade, verifies get_tokens view and rewards.
    • Validates rewards pre-upgrade (v2) and post-consensus (v3) for enabled token only.
  • Register test enable_disable_token_before_after_upgrade_flow_test in src/flow_test/fork_test.cairo.
• Utilities:
  • Import calculate_staker_btc_pool_rewards_v3 to support post-consensus rewards assertions.
• Docs:
  • Remove obsolete section from src/flow_test/flow_ideas.md.

^{Written by Cursor Bugbot for commit e5c165d. This will update automatically on new commits. Configure here.}

[arad-starkware]

• test: add accrue_rewards_across_versions flow #82 : 2 dependent PRs (#83 , #84 )
• test: add attest after upgrade test #71
• test: add token state after upgrade flow #59 👈 (View in Graphite)
• test: add update_rewards toggle tokens flow test #57
• test: add balances delay flow #65
• chore: update flow ideas #61
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[noa-starkware]

Reviewable status: 0 of 3 files reviewed, 5 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/flows.cairo line 7147 at r1 (raw file):

/// Flow:
/// Add tokens A and B

/// Delegate for both tokens

---

src/flow_test/flows.cairo line 7149 at r1 (raw file):

/// Add tokens A and B
/// Enable token B
/// Advance epoch

not relevant to the test, remove from doc

Code quote:

/// Enable token B
/// Advance epoch

---

src/flow_test/flows.cairo line 7237 at r1 (raw file):

        );
        staking_attestation
            .update_rewards_from_attestation_contract(staker_address: staker.staker.address);

why not system.attest(staker)?

---

src/flow_test/flows.cairo line 7237 at r1 (raw file):

        );
        staking_attestation
            .update_rewards_from_attestation_contract(staker_address: staker.staker.address);

test also staker rewards (own+commission from pool a)

---

src/flow_test/flows.cairo line 7250 at r1 (raw file):

        assert!(expected_rewards.is_non_zero());
        assert!(rewards_a == expected_rewards);
        assert!(rewards_b.is_zero());

test also with V3 rewards? we have such test somewhere?

[arad-starkware]

Reviewable status: 0 of 3 files reviewed, 5 unresolved discussions (waiting on @arad-starkware and @noa-starkware)

---

src/flow_test/flows.cairo line 7147 at r1 (raw file):

Previously, noa-starkware wrote…

/// Delegate for both tokens

Done.

---

src/flow_test/flows.cairo line 7149 at r1 (raw file):

Previously, noa-starkware wrote…

not relevant to the test, remove from doc

Done.

---

src/flow_test/flows.cairo line 7237 at r1 (raw file):

Previously, noa-starkware wrote…

why not system.attest(staker)?

Done.

---

src/flow_test/flows.cairo line 7237 at r1 (raw file):

Previously, noa-starkware wrote…

test also staker rewards (own+commission from pool a)

Done.

---

src/flow_test/flows.cairo line 7250 at r1 (raw file):

Previously, noa-starkware wrote…

test also with V3 rewards? we have such test somewhere?

I'm not sure what's the scenario you're describing, testing V3 rewards with disabled tokens after upgrade?

[noa-starkware]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/flows.cairo line 7250 at r1 (raw file):

Previously, arad-starkware wrote…

I'm not sure what's the scenario you're describing, testing V3 rewards with disabled tokens after upgrade?

Yes, just continue the test with start consensus epoch, then call update_rewards and test rewards again (only a token enabled)

---

src/flow_test/flows.cairo line 7191 at r3 (raw file):

        system.advance_epoch();
        system.staking.disable_token(token_address: token_b.contract_address());
        system.staking.enable_token(token_address: token_a.contract_address());

I think these lines might be redundant

Code quote:

        system.staking.disable_token(token_address: token_b.contract_address());
        system.staking.enable_token(token_address: token_a.contract_address());

---

src/flow_test/flows.cairo line 7240 at r3 (raw file):

            calculate_staker_btc_pool_rewards_v2(
            pool_balance: delegation_amount,
            commission: 200,

Suggestion:

system.staker_info_v1(:staker).pool_info.unwrap().commission

[arad-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @arad-starkware and @noa-starkware)

---

src/flow_test/flows.cairo line 7250 at r1 (raw file):

Previously, noa-starkware wrote…

Yes, just continue the test with start consensus epoch, then call update_rewards and test rewards again (only a token enabled)

Done.

---

src/flow_test/flows.cairo line 7191 at r3 (raw file):

Previously, noa-starkware wrote…

I think these lines might be redundant

I wanted to explicitly disable a token instead of just leaving it disabled by default. Do you think it's unnecessary?

---

src/flow_test/flows.cairo line 7240 at r3 (raw file):

            calculate_staker_btc_pool_rewards_v2(
            pool_balance: delegation_amount,
            commission: 200,

Done

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.81%. Comparing base (bb4f50b) to head (e5c165d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          42       42           
  Lines       10194    10194           
=======================================
  Hits         9767     9767           
  Misses        427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arad-starkware]

Merge activity

• Dec 4, 1:07 PM UTC: @arad-starkware merged this pull request with Graphite.