Skip to content

test: find sigma - cover all branches with member from V0#72

Merged
noa-starkware merged 1 commit intomainfrom
noa/staking/v3/test/find-sigma-v0
Nov 27, 2025
Merged

test: find sigma - cover all branches with member from V0#72
noa-starkware merged 1 commit intomainfrom
noa/staking/v3/test/find-sigma-v0

Conversation

@noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Nov 26, 2025

Note

Adds two flow tests covering delegator-from-V0 find-sigma scenarios (zero rewards and cross-version rewards) with corresponding MAINNET_LATEST tests.

  • Flow tests:
    • New DelegatorV0FindSigmaZeroFlow: validates zero unclaimed/claimed rewards for delegator originating in V0 across epochs.
    • New DelegatorRewardsV0FindSigmaFlow: validates delegator rewards when accrued in V0 and V3, asserting view/claim consistency across epochs.
  • Test suite:
    • Add delegator_v0_find_sigma_zero_flow_test and delegator_rewards_v0_find_sigma_flow_test in src/flow_test/fork_test.cairo (MAINNET_LATEST).
  • Docs:
    • Tweak src/flow_test/flow_ideas.md (minor cleanup).

Written by Cursor Bugbot for commit a6a9e37. This will update automatically on new commits. Configure here.


This change is Reviewable

@noa-starkware noa-starkware self-assigned this Nov 26, 2025
@noa-starkware noa-starkware force-pushed the noa/staking/v3/test/delegator-rewards-flow branch from f212092 to ce66cd6 Compare November 26, 2025 12:19
@noa-starkware noa-starkware force-pushed the noa/staking/v3/test/find-sigma-v0 branch from 2ce70ac to c8bfe33 Compare November 26, 2025 12:23
Base automatically changed from noa/staking/v3/test/delegator-rewards-flow to main November 26, 2025 13:44
@noa-starkware noa-starkware force-pushed the noa/staking/v3/test/find-sigma-v0 branch from c8bfe33 to c62bd2b Compare November 26, 2025 13:46
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.71%. Comparing base (a26081a) to head (a6a9e37).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          42       42           
  Lines        9959     9959           
=======================================
  Hits         9532     9532           
  Misses        427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NirLevi-starkware reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noa-starkware)


src/flow_test/flow_ideas.md line 37 at r2 (raw file):

- find sigma: Enter V0, change in V2, catch all ifs.
- find sigma_edge_cases: catch the comments.
- find sigma - cover all branches with member from V0, V1, V2(V2 DONE).

Why these tests down cover all branches with member?

Copy link
Collaborator Author

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NirLevi-starkware)


src/flow_test/flow_ideas.md line 37 at r2 (raw file):

Previously, NirLevi-starkware (Nir Levi) wrote…

Why these tests down cover all branches with member?

Dont understand the question , lets talk in slack

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

@noa-starkware noa-starkware force-pushed the noa/staking/v3/test/find-sigma-v0 branch from c62bd2b to 073d2a8 Compare November 27, 2025 10:56
@noa-starkware noa-starkware enabled auto-merge (squash) November 27, 2025 10:57
Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

@noa-starkware noa-starkware force-pushed the noa/staking/v3/test/find-sigma-v0 branch from 7519bc0 to a6a9e37 Compare November 27, 2025 11:17
@noa-starkware noa-starkware merged commit 73c593a into main Nov 27, 2025
5 of 6 checks passed
@noa-starkware noa-starkware deleted the noa/staking/v3/test/find-sigma-v0 branch November 27, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants