Skip to content

Conversation

@noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Nov 26, 2025

Note

Adds six new staker-from-V2 migration flow tests (various balance/epoch/attestation sequences) and registers them in mainnet fork tests; minor flow ideas doc tweak.

  • Flow tests (Cairo):
    • Add StakerFromV2Flow1..StakerFromV2Flow6 in src/flow_test/flows.cairo covering V2→V3 staker migration scenarios with different sequences of balance updates, epoch advances, attestations, and reward validations.
    • Register corresponding tests in src/flow_test/fork_test.cairo (staker_from_v2_flow_{1..6}_flow_test).
  • Docs:
    • Tweak src/flow_test/flow_ideas.md staker migration ideas list.

Written by Cursor Bugbot for commit 2528fbb. This will update automatically on new commits. Configure here.


This change is Reviewable

@noa-starkware noa-starkware self-assigned this Nov 26, 2025
@noa-starkware noa-starkware force-pushed the noa/staking/v3/test/multiple-pools-flow branch from e40d3b0 to e85847f Compare November 27, 2025 09:44
Base automatically changed from noa/staking/v3/test/multiple-pools-flow to main November 27, 2025 09:53
@noa-starkware noa-starkware force-pushed the noa/staking/v3/test/migration-staker-k-2 branch from 0b67e23 to 0c4a6c4 Compare November 27, 2025 21:01
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.77%. Comparing base (d25df14) to head (2528fbb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          42       42           
  Lines       10102    10102           
=======================================
  Hits         9675     9675           
  Misses        427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noa-starkware)

@noa-starkware noa-starkware enabled auto-merge (squash) November 30, 2025 07:44
@noa-starkware noa-starkware merged commit 9734730 into main Nov 30, 2025
5 of 6 checks passed
@noa-starkware noa-starkware deleted the noa/staking/v3/test/migration-staker-k-2 branch November 30, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants