-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add burnable mock erc20 #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage ? 89.06%
=======================================
Files ? 43
Lines ? 2387
Branches ? 0
=======================================
Hits ? 2126
Misses ? 261
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
89b8b22 to
446c612
Compare
remollemo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ishay-starkware and @noa-starkware)
a discussion (no related file):
- how is it applicable in current context?
- allowing any user to burn to any other user is a bit aggressive even for testing... although legit
- might be handy to be able to create supply as well
446c612 to
866324e
Compare
5ee2e4e to
f57716b
Compare
remollemo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @arad-starkware, @ishay-starkware, and @noa-starkware)
packages/utils/src/erc20/erc20_mocks.cairo line 68 at r3 (raw file):
} } }
if you're DualCase implement the IMintableTokenCamel as well
f57716b to
3af3954
Compare
arad-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @ishay-starkware, @noa-starkware, and @remollemo)
a discussion (no related file):
Previously, remollemo wrote…
- how is it applicable in current context?
- allowing any user to burn to any other user is a bit aggressive even for testing... although legit
- might be handy to be able to create supply as well
Done.
packages/utils/src/erc20/erc20_mocks.cairo line 68 at r3 (raw file):
Previously, remollemo wrote…
if you're DualCase implement the
IMintableTokenCamelas well
Done.
remollemo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remollemo reviewed 1 of 2 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ishay-starkware and @noa-starkware)
Merge activity
|

This change is
Note
Adds ownable-controlled mint/burn to
DualCaseERC20Mockand introducesIMintableToken(+ camelCase variant) interfaces.packages/utils/src/erc20/erc20_mocks.cairoDualCaseERC20Mock:OwnableComponent(storage + events) and initializes ownership in constructor.owner(replacesrecipient) and mints initial supply toowner.IMintableTokenandIMintableTokenCamelOnlywith owner-restrictedpermissioned_mint/permissioned_burnandis_permitted_minter.packages/utils/src/interfaces/mintable_token.cairo: AddsIMintableTokenandIMintableTokenCamelOnlytraits.Written by Cursor Bugbot for commit 3af3954. This will update automatically on new commits. Configure here.