Skip to content

Conversation

@noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Nov 6, 2025

Note

Adds a new span module with a generic contains function to check membership in a Span<T>.

  • Utilities:
    • New span module:
      • Add contains<T>(span: Span<T>, value: T) -> bool to check if a Span<T> contains a value.
    • Export span in packages/utils/src/lib.cairo.

Written by Cursor Bugbot for commit e32c43b. This will update automatically on new commits. Configure here.


This change is Reviewable

@noa-starkware noa-starkware self-assigned this Nov 6, 2025
@noa-starkware noa-starkware changed the title feat(span): add contains function for span feat(utils): add contains function for span Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@953a839). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage        ?   89.06%           
=======================================
  Files           ?       43           
  Lines           ?     2387           
  Branches        ?        0           
=======================================
  Hits            ?     2126           
  Misses          ?      261           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@remollemo remollemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @noa-starkware)

@noa-starkware noa-starkware merged commit 7183b23 into main Nov 6, 2025
5 of 6 checks passed
@noa-starkware noa-starkware deleted the noa/span/contains branch November 6, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants