Skip to content

Conversation

@remollemo
Copy link
Collaborator

@remollemo remollemo commented Nov 9, 2025

Note

Switches replace_to access control from only_upgrade_governor to only_upgrader, refactors EIC handling, and updates the related test expectation.

  • Replaceability:
    • Access Control: replace_to now requires Roles::only_upgrader (upgrade agent or governor) instead of only_upgrade_governor in packages/utils/src/components/replaceability/replaceability.cairo.
    • EIC Init: Refactors Option handling to if let when invoking library_call_syscall.
  • Tests:
    • Update panic expectation to "ONLY_UPGRADER" in packages/utils/src/components/replaceability/test.cairo.

Written by Cursor Bugbot for commit 327a763. This will update automatically on new commits. Configure here.


This change is Reviewable

@remollemo remollemo self-assigned this Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@ebd4fdb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...src/components/replaceability/replaceability.cairo 85.71% 1 Missing ⚠️
...ges/utils/src/components/replaceability/test.cairo 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage        ?   89.34%           
=======================================
  Files           ?       43           
  Lines           ?     2478           
  Branches        ?        0           
=======================================
  Hits            ?     2214           
  Misses          ?      264           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator Author

@remollemo remollemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remollemo reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @remollemo)

@remollemo remollemo force-pushed the remo/replacability/only_upgrader-applied branch from e4378e5 to 7fa04f8 Compare November 10, 2025 16:12
Copy link
Collaborator

@RoeeGross RoeeGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoeeGross reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @remollemo)

@remollemo remollemo force-pushed the remo/replacability/only_upgrader-applied branch from 7fa04f8 to 8a7016f Compare November 18, 2025 12:38
@remollemo remollemo force-pushed the remo/replacability/only_upgrader-applied branch from 8a7016f to 327a763 Compare November 25, 2025 11:34
@remollemo remollemo merged commit 7b46975 into main Nov 25, 2025
6 checks passed
@remollemo remollemo deleted the remo/replacability/only_upgrader-applied branch November 25, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants