Skip to content

Conversation

@ItayRosenberg
Copy link
Contributor

@ItayRosenberg ItayRosenberg commented Nov 10, 2025

Note

Adds a helper to deploy the mock ERC20 and updates TokenDeployImpl.deploy to use it.

  • Testing utils (packages/testing/src/test_utils.cairo):
    • New helper: deploy_mock_erc20_contract builds calldata and deploys DualCaseERC20Mock, returning its ContractAddress.
    • Refactor: TokenDeployImpl.deploy now delegates to deploy_mock_erc20_contract instead of inlining deployment logic.

Written by Cursor Bugbot for commit 527c4e6. This will update automatically on new commits. Configure here.


This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@475ee83). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage        ?   89.36%           
=======================================
  Files           ?       43           
  Lines           ?     2464           
  Branches        ?        0           
=======================================
  Hits            ?     2202           
  Misses          ?      262           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ishay-starkware ishay-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ishay-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ItayRosenberg)

@ItayRosenberg ItayRosenberg merged commit 5de28fd into main Nov 10, 2025
6 checks passed
@ItayRosenberg ItayRosenberg deleted the itay/add_deploy_erc20_mock_function branch November 10, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants