Skip to content

Conversation

@noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Dec 3, 2025

Note

Adds only_governance_admin internal guard and introduces ONLY_GOVERNANCE_ADMIN error variant/message.

  • Roles:
    • Add only_governance_admin check in roles.cairo internal trait to assert caller is GOVERNANCE_ADMIN.
  • Errors:
    • Add ONLY_GOVERNANCE_ADMIN to AccessErrors with description "ONLY_GOVERNANCE_ADMIN".

Written by Cursor Bugbot for commit 0cdda53. This will update automatically on new commits. Configure here.


This change is Reviewable

@noa-starkware noa-starkware self-assigned this Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@7b46975). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/utils/src/components/roles/errors.cairo 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage        ?   89.26%           
=======================================
  Files           ?       43           
  Lines           ?     2479           
  Branches        ?        0           
=======================================
  Hits            ?     2213           
  Misses          ?      266           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noa-starkware noa-starkware marked this pull request as draft December 3, 2025 17:51
@noa-starkware noa-starkware removed the request for review from remollemo December 3, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants