feat(testing_utils): add set_account_as_security_governor function#142
Merged
noa-starkware merged 2 commits intomainfrom Dec 10, 2025
Merged
feat(testing_utils): add set_account_as_security_governor function#142noa-starkware merged 2 commits intomainfrom
noa-starkware merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage ? 89.39%
=======================================
Files ? 43
Lines ? 2481
Branches ? 0
=======================================
Hits ? 2218
Misses ? 263
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NirLevi-starkware
approved these changes
Dec 10, 2025
Collaborator
NirLevi-starkware
left a comment
There was a problem hiding this comment.
@NirLevi-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @remollemo)
remollemo
approved these changes
Dec 10, 2025
Collaborator
remollemo
left a comment
There was a problem hiding this comment.
@remollemo reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds
SECURITY_GOVERNORconstant and a test utility to register security governors, wiring it into default role setup.set_account_as_security_governorto register a security governor viaIRolesDispatcher.set_default_rolesto assigntesting_constants::SECURITY_GOVERNORusing the new helper.SECURITY_GOVERNORtopackages/testing/src/constants.cairo.Written by Cursor Bugbot for commit 7f872e4. This will update automatically on new commits. Configure here.
This change is