Skip to content

Comments

feat(testing_utils): add set_account_as_security_governor function#142

Merged
noa-starkware merged 2 commits intomainfrom
noa/set_account_as_security_governor
Dec 10, 2025
Merged

feat(testing_utils): add set_account_as_security_governor function#142
noa-starkware merged 2 commits intomainfrom
noa/set_account_as_security_governor

Conversation

@noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Dec 10, 2025

Note

Adds SECURITY_GOVERNOR constant and a test utility to register security governors, wiring it into default role setup.

  • Testing utils:
    • Add set_account_as_security_governor to register a security governor via IRolesDispatcher.
    • Update set_default_roles to assign testing_constants::SECURITY_GOVERNOR using the new helper.
  • Constants:
    • Add SECURITY_GOVERNOR to packages/testing/src/constants.cairo.

Written by Cursor Bugbot for commit 7f872e4. This will update automatically on new commits. Configure here.


This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ef6cf3b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage        ?   89.39%           
=======================================
  Files           ?       43           
  Lines           ?     2481           
  Branches        ?        0           
=======================================
  Hits            ?     2218           
  Misses          ?      263           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @remollemo)

Copy link
Collaborator

@remollemo remollemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@remollemo reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

@noa-starkware noa-starkware enabled auto-merge (squash) December 10, 2025 12:05
@noa-starkware noa-starkware merged commit 1b37730 into main Dec 10, 2025
4 checks passed
@noa-starkware noa-starkware deleted the noa/set_account_as_security_governor branch December 10, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants