feat: add start time arg in devnet infra #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage ? 89.33%
=======================================
Files ? 43
Lines ? 2484
Branches ? 0
=======================================
Hits ? 2219
Misses ? 265
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RoeeGross
approved these changes
Dec 25, 2025
Collaborator
RoeeGross
left a comment
RoeeGross
left a comment
There was a problem hiding this comment.
@RoeeGross reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noa-starkware).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds optional time-control to devnet startup for tests.
StarknetTestUtilsandStarknetconstructors and context manager to acceptstart_time: Optional[int]start_timetostarknet-devnetby appending--start-time <value>to the launch command when providedWritten by Cursor Bugbot for commit 368a2ae. This will update automatically on new commits. Configure here.
This change is