Open
Conversation
giladchase
force-pushed
the
gilad/add-types
branch
from
deba8c7 to
ad7f13c
Compare
giladchase
changed the title
PackedCasmState there
giladchase
force-pushed
the
gilad/add-types
branch
from
ad7f13c to
92393ef
Compare
shaharsamocha7
approved these changes
Feb 2, 2025
Contributor
shaharsamocha7
left a comment
shaharsamocha7
left a comment
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
giladchase
force-pushed
the
gilad/addap
branch
from
3481381 to
0e0ba19
Compare
giladchase
force-pushed
the
gilad/add-types
branch
from
92393ef to
bd7b3da
Compare
move [Packed]CasmState there, including rename VmState -> CasmState
giladchase
force-pushed
the
gilad/add-types
branch
from
bd7b3da to
20c9307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move [Packed]CasmState there, including rename VmState -> CasmState
This change is