Open
Conversation
added 7 commits
January 19, 2025 14:26
- follows current design in stwo-cairo for this opcode. - inline write_trace_row - add LookupData that wraps InteractionClaimGenerator fields, which also holds n_calls. - fix edge cases if input is smaller than LOG_N_LANES
move [Packed]CasmState there, including rename VmState -> CasmState
giladchase
force-pushed
the
gilad/add-mul-imm-rest
branch
2 times, most recently
from
dff3735 to
a29c871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure on this one, but the spec that i did with Titelman back in the day seems to hint at this impl. I think he mentioned doing a jz instead of a jnz in order to save traces, but i'm not sure.
This change is