Skip to content

Add TestLessThan hint.#69

Open
ilyalesokhin-starkware wants to merge 1 commit intomainfrom
ilya/lt
Open

Add TestLessThan hint.#69
ilyalesokhin-starkware wants to merge 1 commit intomainfrom
ilya/lt

Conversation

@ilyalesokhin-starkware
Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware commented Mar 2, 2025

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)


crates/runnair/src/utils.rs line 4 at r1 (raw file):

use stwo_prover::core::fields::m31::M31;
// use stwo_prover::core::fields::qm31::QM31;

this doesn't break anything?


crates/runnair/src/vm/hints.rs line 39 at r1 (raw file):

        rhs: ResOperand,
        dst: CellRef,
    },

can AllocateSegment be supported?

@ilyalesokhin-starkware ilyalesokhin-starkware force-pushed the ilya/lt branch 2 times, most recently from 031014c to cb490fe Compare March 2, 2025 15:45
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 4 of 8 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r2, 3 of 4 files at r3, all commit messages.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants