Skip to content

add_mul_imm complex numbers#70

Merged
Gali-StarkWare merged 1 commit intomainfrom
gali/add_mul_imm_complex
Mar 2, 2025
Merged

add_mul_imm complex numbers#70
Gali-StarkWare merged 1 commit intomainfrom
gali/add_mul_imm_complex

Conversation

@Gali-StarkWare
Copy link
Collaborator

@Gali-StarkWare Gali-StarkWare commented Mar 2, 2025

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Gali-StarkWare Gali-StarkWare self-assigned this Mar 2, 2025
@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review March 2, 2025 14:35
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare)


crates/prover/src/utils/mod.rs line 34 at r1 (raw file):

        let two = T::one() + T::one();
        let selector_minus_2 = selector.clone() - two.clone();
        let field_half = (0..30).fold(T::one(), |acc, _| acc.clone() * two.clone());

We should put a TODO to remove it

Code quote:

let field_half = (0..30).fold(T::one(), |acc, _| acc.clone() * two.clone());

@Gali-StarkWare Gali-StarkWare merged commit 400bf30 into main Mar 2, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants