Bitwise (and other builtins) memory optimization.

[ormarx-starkware]

This change is 

[yuvalsw]

@yuvalsw made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @ormarx-starkware).

---

stwo_cairo_prover/crates/prover/src/witness/components/mul_mod_builtin.rs line 60 at r1 (raw file):

        for inputs in sub_component_inputs.range_check_18 {
            range_check_18_state.add_packed_inputs(&inputs);
        }

Can these be done using nested for loops?
I guess these are auto generated, right? There is a separate PR in air-infra for the autogeneration code change?

Code quote:

        for inputs in sub_component_inputs.memory_address_to_id {
            memory_address_to_id_state.add_packed_inputs(&inputs);
        }
        for inputs in sub_component_inputs.memory_id_to_big {
            memory_id_to_big_state.add_packed_inputs(&inputs);
        }
        for inputs in sub_component_inputs.range_check_12 {
            range_check_12_state.add_packed_inputs(&inputs);
        }
        for inputs in sub_component_inputs.range_check_3_6_6_3 {
            range_check_3_6_6_3_state.add_packed_inputs(&inputs);
        }
        for inputs in sub_component_inputs.range_check_18 {
            range_check_18_state.add_packed_inputs(&inputs);
        }

[ormarx-starkware]

@ormarx-starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware and @yuvalsw).

---

stwo_cairo_prover/crates/prover/src/witness/components/mul_mod_builtin.rs line 60 at r1 (raw file):

Previously, yuvalsw wrote…

Can these be done using nested for loops?
I guess these are auto generated, right? There is a separate PR in air-infra for the autogeneration code change?

This PR only demonstrates the change. AFAIU the code here is auto-generated, and @anatgstarkware 's team will work on it.

[anatgstarkware]

stwo_cairo_prover/crates/prover/src/witness/components/mul_mod_builtin.rs line 60 at r1 (raw file):

Previously, ormarx-starkware wrote…

This PR only demonstrates the change. AFAIU the code here is auto-generated, and @anatgstarkware 's team will work on it.

Already merged, please close the pr